Perf improvement to getting auth chains #17169
Open
+93
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/faster_auth_chains
branch
from
5b3845d
to
a2adc9c
Compare
erikjohnston
force-pushed
the
erikj/faster_auth_chains
branch
from
a2adc9c
to
ca79b4d
Compare
3 tasks
|
@erikjohnston I applied this patch on 1.106.0 and unfortunately it does not really improve. Very long 
|
erikjohnston
force-pushed
the
erikj/faster_auth_chains
branch
from
46a0c20
to
ca79b4d
Compare
|
The old code also removed the chains that |
heftig
reviewed
May 15, 2024
| @@ -581,7 +592,7 @@ def fetch_chain_info(events_to_fetch: Collection[str]) -> None: | |||
| # are reachable from any event. | |||
|
|
|||
| # (We need to take a copy of `seen_chains` as the function mutates it) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this helps.
--
Regression introduced in #17044
Fixes: #17129
Replaces: #17154