-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pre-requisites for building native modules on linux and updated native-node-modules.md #344
base: develop
Are you sure you want to change the base?
Conversation
(You could have force pushed to your branch after cleaning locally) You did not address my comment. |
@andybalaam Hi, could you re-review this PR?
Sorry, was facing some issues, my bad. |
Since it's the dependency is taken care of and the user doesn't need to run any command, I've removed the sentence as it felt unnecessary. Does that work? |
Fine by me, but I’m not in anyway a decision maker here. ;) |
Unfortunately the story with SQLCipher here is a bit more complex. The doc says to add matrix seshat directly with yarn, which I think is a bit odd (I filed element-hq/element-web#21883 for that) but this means it won't build its own SQLCipher, static or otherwise, like it does when running In general, I'd prefer that we didn't copy & paste installation instructions for everything into our doc, as it's more for us to keep up to date: I'd suggest just referring to the project homepage and telling the user to install things however they prefer. On Node, I wouldn't bother with this in this doc at all since it's necessary for building the app at all, not just the native modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbkr's comment needs addressing.
Added file
linux-requirements.md
inelement-desktop/docs
and updatednative-node-modules.md
, put the config part before the yarn start step for more clarity. Also added steps to install SQLCipher library in Adding Seshat for search in E2E encrypted rooms. Made all the changes requested on the previous PR.PS: Created a new PR due to some merging issues faced
Signed-off-by: Shreeya shreeya.singh@students.iiit.ac.in
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.