fix can't show chinese on mac platform app menu. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on mac platform just as Edit Undo don't translate because fetchTranslationJson parameter is zh-hans.json but not zh_Hans.json. |
|
also on windows 10 if you press alt when app start. |
turt2live
requested changes
Jan 17, 2022
There was a problem hiding this comment.
Thank you for taking a look at fixing this! Unfortunately we can't accept the change in this way because renaming i18n json files has a lot of side effects we want to avoid.
Instead, it sounds like the code which tries to use the translation files needs to be investigated and fixed to ensure it using the same language codes as the rest of the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.