Fix Could not fetch translation json for locale: 'de' #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
|
I am not really happy with the amount of logging, as every locale that cannot be found produces a stack trace like this: Changing application language to de
Fetching translation json for locale: de
Could not fetch translation json for locale: 'de' Error: Cannot find module './i18n/strings/de.json'
Require stack:
- /opt/Element/resources/app.asar/lib/language-helper.js
- /opt/Element/resources/app.asar/lib/tray.js
- /opt/Element/resources/app.asar/lib/settings.js
- /opt/Element/resources/app.asar/lib/ipc.js
- /opt/Element/resources/app.asar/lib/electron-main.js
-
at node:internal/modules/cjs/loader:1084:15
at Function._resolveFilename (node:electron/js2c/browser_init:2:116646)
at node:internal/modules/cjs/loader:929:27
at Function._load (node:electron/js2c/asar_bundle:2:13327)
at Module.require (node:internal/modules/cjs/loader:1150:19)
at require (node:internal/modules/cjs/helpers:121:18)
at AppLocalization.fetchTranslationJson (/opt/Element/resources/app.asar/lib/language-helper.js:96:20)
at /opt/Element/resources/app.asar/lib/language-helper.js:109:39
at Array.filter (<anonymous>)
at AppLocalization.setAppLocale (/opt/Element/resources/app.asar/lib/language-helper.js:108:86) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/opt/Element/resources/app.asar/lib/language-helper.js',
'/opt/Element/resources/app.asar/lib/tray.js',
'/opt/Element/resources/app.asar/lib/settings.js',
'/opt/Element/resources/app.asar/lib/ipc.js',
'/opt/Element/resources/app.asar/lib/electron-main.js',
undefined
]
}
Fetching translation json for locale: de_DE
Resetting the UI components after locale change
This only affects |
Nils1729
force-pushed
the
language-variations
branch
2 times, most recently
from
e969eb7
to
0d510d0
Compare
added 3 commits
February 21, 2024 10:40
AppLocalization.setAppLocale uses `!!translations` to check if a
locale is avaliable, but `!!{} === true`.
Thus, any localization was considered valid, even `{}`, which was
returned from `AppLocalization.fetchTranslationJson` when no such
locale was found.
This does not happen when we return `null` since it is falsy.
Signed-off-by: Nils Hanff <nils.hanff@giz.berlin>
The method returns suitable fallbacks in case a locale is not found. Signed-off-by: Nils Hanff <nils.hanff@giz.berlin>
Signed-off-by: Nils Hanff <nils.hanff@giz.berlin>
Nils1729
force-pushed
the
language-variations
branch
from
0d510d0
to
2ca86f7
Compare
t3chguy
reviewed
Mar 11, 2024
| const parts = locale.split("-"); | ||
| if (parts.length > 1) { | ||
| parts[1] = parts[1].toUpperCase(); | ||
| } | ||
| return parts.join("_"); | ||
| } | ||
|
|
||
| public fetchTranslationJson(locale: string): Record<string, string> { | ||
| public fetchTranslationJson(locale: string): object | null { |
There was a problem hiding this comment.
object is too loose here, please use a better type
| @@ -91,25 +91,35 @@ export class AppLocalization { | |||
| this.resetLocalizedUI(); | |||
| } | |||
|
|
|||
| // Fallbacks to a locale (e.g. en-gb to [en-gb, en, en-en] or just en to [en, en-en]) | |||
| private variations(locale: string): string[] { | |||
There was a problem hiding this comment.
Can we use getNormalizedLanguageKeys from matrix-web-i18n to remain consistent across the layers?
|
Drafting this because it is not critical and seems rather complex. I'll come back once I have some more time at hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1419.
Checklist
In implementation it turned out that it was the opposite problem than in the comment: There is no generic
de, only the specificde_DE. I tried to cover this case as generically as possible, although it only occurs withenanddeat the time of writing.Type: defect