Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text to readme to specify how to build the webapp.asar file #1324

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add text to readme to specify how to build the webapp.asar file #1324

wants to merge 1 commit into from

Conversation

bceverly
Copy link

@bceverly bceverly commented Nov 10, 2023 •
edited by github-actions bot

Checklist

  • [ X] Ensure your code works with manual testing
  • [ X] Linter and other CI checks pass
  • [ X] Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Add text to readme to specify how to build the webapp.asar file (#1324). Contributed by @bceverly.

@bceverly bceverly requested a review from a team as a code owner November 10, 2023 11:36
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Enhancement labels Nov 10, 2023
t3chguy
t3chguy requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's quite right, as the text right before the code block says "don't need to build packages" - for which you indeed do not need to use yarn asar-webapp

@richvdh richvdh changed the title Added text to readme to specify how to build the webapp.asar file Add text to readme to specify how to build the webapp.asar file Nov 13, 2023
@richvdh richvdh removed their request for review November 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy requested changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bceverly @t3chguy