Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for icons. #8

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Implement support for icons. #8

merged 4 commits into from
Jun 5, 2023

Conversation

pixlwave
Copy link
Collaborator

@pixlwave pixlwave commented Jun 5, 2023

This PR makes the following changes:

  • Adds a CompoundIcon component that works similarly to Image(systemName:) whereby it reads the current font size and scales with it appropriately.
  • Adds a CompoundIcons struct that contains a manual mapping of all the tokens so we can use them via a KeyPath as the style dictionary is currently fixed to generate static properties (PR to fix this is here).
  • Adds a dynamic type setting to the inspector when used on a Mac and adopts SwiftUI's new value based navigation so this is only applied to the detail view's contents.
  • Updates to the latest revision of the tokens repo.

@pixlwave pixlwave requested a review from a team as a code owner June 5, 2023 10:45
@pixlwave pixlwave requested review from Velin92 and removed request for a team June 5, 2023 10:45
@pixlwave pixlwave merged commit aaa4340 into main Jun 5, 2023
@pixlwave pixlwave deleted the doug/icons branch June 5, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants