Update Swift icon generation to output properties as members. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
approved these changes
Jan 8, 2024
| @@ -0,0 +1,30 @@ | |||
| <% | |||
| // | |||
| // Copyright 2019 Alaska Air Group or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Is this intentional? (this file is actually code from another org?)
There was a problem hiding this comment.
Ah yeah I should add a comment that this is based on any.swift.template from the style dictionary source with a small tweak to remove the static keyword.
Germain actually opened a PR to handle this upstream but so far it hasn't been reviewed.
| } | ||
| } | ||
|
|
||
| const swiftKeywords = [ |
There was a problem hiding this comment.
Could you add a link to where you've sourced these from?
There was a problem hiding this comment.
Updated and added some more that I missed (in reality there is one icon called public that caused issues but seemed worthwhile to handle as many as possible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than manually mapping the icons in compound-ios this change creates them in a format that is directly usable for us. Part of element-hq/element-x-ios#2101
The first commit contains all the changes to the generator, the second contains the updated assets.
We should do similar for colours too, although we would need element-hq/compound#93 fixed before that is possible.