Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document rfc process #1

Merged
merged 15 commits into from Jan 8, 2024
Merged

chore: document rfc process #1

merged 15 commits into from Jan 8, 2024

Conversation

erickzhao
Copy link
Member

No description provided.

@erickzhao erickzhao requested a review from a team November 7, 2023 02:48
samuelmaddock
samuelmaddock approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process is well thought out and didn't leave anything out that came to mind while reading through it 👍

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
erickzhao and others added 2 commits November 8, 2023 10:48
@erickzhao
address feedback on Completed status
08c6283
@erickzhao @samuelmaddock
Update README.md
8fcba8c 
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
jkleinsc
jkleinsc approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsanders11
dsanders11 reviewed Nov 14, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@erickzhao @dsanders11
unify declined language
ea159c0 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@erickzhao @dsanders11
Update .github/workflows/semantic.yml
01cf86e 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@samuelmaddock
Copy link
Member

React's RFC process uses a react core team label. Maybe we could use the same idea for maintainer RFCs.

samuelmaddock
samuelmaddock reviewed Nov 15, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
nornagon
nornagon reviewed Nov 21, 2023
View reviewed changes
README.md Show resolved Hide resolved
nornagon
nornagon reviewed Nov 21, 2023
View reviewed changes
README.md Show resolved Hide resolved
nornagon
nornagon reviewed Nov 22, 2023
View reviewed changes
0000-template.md Outdated Show resolved Hide resolved
0000-template.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
erickzhao and others added 2 commits January 5, 2024 11:01
@erickzhao
"consensus"
afd9c6a
@jkleinsc @samuelmaddock
Update README.md
018ff27 
Co-authored-by: Sam Maddock <samuel.maddock@gmail.com>
@jkleinsc jkleinsc merged commit ab80474 into main Jan 8, 2024
2 checks passed
@jkleinsc jkleinsc deleted the rfc-draft branch January 8, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@nornagon nornagon nornagon approved these changes

@itsananderson itsananderson itsananderson approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@erickzhao @samuelmaddock @ckerr @nornagon @itsananderson @jkleinsc @codebytere @VerteDinde @dsanders11