New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: align test save location configs #3585
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's still having trouble with Windows.
Thank you for this! |
I just merged main with no additional changes to the previous, and surprisingly filename timings across all platforms were detected. This makes me think that the timing detection issue we saw on the previous slow Windows CI run wasn't caused by outputting OS incompatible relative paths. My theory right now is that the path detection relies on testing output from previous circle runs. I wish I could ssh into the circle testing machines to confirm the content of the test folder and get a better mental model, but it looks like Rerun with SSH is disabled. I want to confirm the following:
|
Summarize your changes:
CircleCI can't detect previous test timing data. Fixing this by tweaking the script we use to ensure filepaths in the junit xml files are using relative paths
Testing:
CI=1 yarn test --suite="slow"