feat: only include provided upload options in publisher-gcs #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
reviewed
May 2, 2024
| @@ -23,24 +23,26 @@ export default class PublisherGCS extends PublisherStatic<PublisherGCSConfig> { | |||
| async publish({ makeResults, setStatusLine }: PublisherOptions): Promise<void> { | |||
| const artifacts: GCSArtifact[] = []; | |||
|
|
|||
| if (!this.config.bucket) { | |||
| const { storageOptions, bucket: configBucket, folder, ...uploadOptions } = this.config; | |||
There was a problem hiding this comment.
question: I haven't tested this locally yet but we do have a custom keyResolver property in the Config as well that would get rolled up with ...uploadOptions. Would passing in that unknown key into bucket.upload trigger an error on the GCS SDK side?
There was a problem hiding this comment.
I haven't had any trouble with it, and it doesn't look like there's any checking for extraneous keys in their library. That could change, of course.
We could also pull out keyResolver here if you think it's a concern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
bucket.uploadif they are specified by the user.I was facing an issue where artifacts could not be uploaded to a bucket that had uniform bucket-level access, which essentially meant that files could not be uploaded that had specified
privateorpublicorpredefinedAcl. This change removes those fields from thebucket.uploadcall unless they are added by the user.