New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: partially revert invalidate focus ring #42126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tldr: 👍 to everything @VerteDinde said in the description.
- I've confirmed this fixes the issue for me in local builds
- This is a reasonable way to unblock releases while we figure out the root cause
- Once we track down the root cause, it would be preferable to fix that and drop this patch if possible
Release Notes Persisted
|
I have automatically backported this PR to "30-x-y", please check out #42145 |
I have automatically backported this PR to "31-x-y", please check out #42146 |
chore: update patches after focus ring was merged
Description of Change
Fixes #41839
We were seeing an inconsistent segfault on Ubuntu and several other Linux distros, and traced it back to this CL:https://chromium-review.googlesource.com/c/chromium/src/+/5344356. It appeats that the current upstream layout invalidation logic doesn't always invalidate a parent and child correctly. A label's bounds could change without being invalidated because its container can change its bounds.
We should handle this layout logic to better handle parent/child invalidation (see #41899, which is in progress) and upstream a fix if possible, but this PR should unblock developers wanting to upgrade to E31 and E30.
cc @ckerr @Kilian
Checklist
npm test
passesRelease Notes
Notes: Fixed an inconsistent crash on maximizing window and relayout in Ubuntu.