New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump chromium to 127.0.6498.3 (main) #42118
Open
electron-roller
wants to merge
65
commits into
main
Choose a base branch
from
roller/chromium/main
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,003
−758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-roller
bot
added
no-backport
semver/patch
backwards-compatible bug fixes
labels
May 10, 2024
electron-roller
bot
changed the title
chore: bump chromium to 126.0.6470.0 (main)
chore: bump chromium to 126.0.6472.0 (main)
May 11, 2024
electron-roller
bot
changed the title
chore: bump chromium to 126.0.6472.0 (main)
chore: bump chromium to 126.0.6474.0 (main)
May 12, 2024
electron-roller
bot
changed the title
chore: bump chromium to 126.0.6474.0 (main)
chore: bump chromium to 126.0.6476.0 (main)
May 13, 2024
jkleinsc
added
target/31-x-y
PR should also be added to the "31-x-y" branch.
and removed
no-backport
labels
May 13, 2024
electron-roller
bot
changed the title
chore: bump chromium to 126.0.6476.0 (main)
chore: bump chromium to 126.0.6478.0 (main)
May 14, 2024
electron-roller
bot
changed the title
chore: bump chromium to 126.0.6478.0 (main)
chore: bump chromium to 126.0.6478.3 (main)
May 15, 2024
electron-roller
bot
changed the title
chore: bump chromium to 127.0.6495.0 (main)
chore: bump chromium to 127.0.6496.0 (main)
May 23, 2024
See patch message for more details. https://chromium-review.googlesource.com/c/v8/v8/+/5526611
https://chromium-review.googlesource.com/c/chromium/src/+/5526034 The title is a bit misleading. They removed handling for the feature flag and generally intend to remove it but haven't yet. I only changed our code to address the flag that was removed. A quick search on GitHub for `DnsOverHttpsFallback` yielded a few results, but they were all C++ chromium code or patches, 0 app code or discussion results. Since I couldn't find any evidence of this flag being used in developer applications, I've chosen to exclude this change from the breaking changes docs.
https://chromium-review.googlesource.com/c/v8/v8/+/5497515 See patch message for more details.
Node.js PR: nodejs/node#52996 V8 API Removal CL: https://chromium-review.googlesource.com/c/v8/v8/+/5539888 See the patch description for more details.
https://chromium-review.googlesource.com/c/v8/v8/+/5539888 This commit essentially only removes the `only_terminate_in_safe_scope` isolate creation parameter. This undoes some work that was originally done in #35766.
https://chromium-review.googlesource.com/c/chromium/src/+/5545807 I took a systematic approach to modifying all of our uses of `NOTREACHED` that were causing errors: * If there was a `return` or `break` (etc.) immediately after `NOTREACHED`, I removed the control flow instruction and left the `NOTREACHED` unmodified * All other instances were migrated to `NOTREACHED_IN_MIGRATION` We should revisit pretty much all usage of `NOTREACHED` as an upgrade follow-up item.
…ium-review.googlesource.com/c/chromium/src/+/5526034 Turns out the feature flags were removed in the `.cc` file, but not the `.h` feature list file. This means that the feature flags are pretty much officially gone. (The leftover symbols in the header are likely an oversight from what I can gather.) We may potentially decide to put this in the breaking changes doc if we decide this feature flag is important enough to highlight.
electron-roller
bot
changed the title
chore: bump chromium to 127.0.6496.0 (main)
chore: bump chromium to 127.0.6498.3 (main)
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Chromium to 127.0.6498.3.
See all changes in 126.0.6445.0..127.0.6498.3
Notes: Updated Chromium to 127.0.6498.3.