fix: requestFullscreen from WebContentsView (#41995)

fix: requestFullscreen from WebContentsView

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

shell/browser/api/electron_api_web_contents_view.cc

@@ -89,6 +89,9 @@ void WebContentsView::OnViewAddedToWidget(views::View* observed_view) {
       widget->GetNativeWindowProperty(electron::kElectronNativeWindowKey));
   if (!native_window)
     return;
+  // We don't need to call SetOwnerWindow(nullptr) in OnViewRemovedFromWidget
+  // because that's handled in the WebContents dtor called prior.
+  api_web_contents_->SetOwnerWindow(native_window);
   native_window->AddDraggableRegionProvider(this);
 }
 

spec/api-web-contents-view-spec.ts

@@ -60,6 +60,18 @@ describe('WebContentsView', () => {
     });
   });
 
+  it('can be fullscreened', async () => {
+    const w = new BaseWindow();
+    const v = new WebContentsView();
+    w.setContentView(v);
+    await v.webContents.loadURL('data:text/html,<div id="div">This is a simple div.</div>');
+
+    const enterFullScreen = once(w, 'enter-full-screen');
+    await v.webContents.executeJavaScript('document.getElementById("div").requestFullscreen()', true);
+    await enterFullScreen;
+    expect(w.isFullScreen()).to.be.true('isFullScreen');
+  });
+
   describe('visibilityState', () => {
     it('is initially hidden', async () => {
       const v = new WebContentsView();