Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e sync, compare paths with no case #589

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andrewsml
Copy link

@andrewsml andrewsml commented May 6, 2024

Closes #588

Path returned by git rev-parse --show-toplevel after normalizing contain C: drive in upper case, so further string comparison fails

@andrewsml andrewsml requested review from ckerr and a team as code owners May 6, 2024 10:59
@codebytere codebytere changed the title fix: e sync, compare paths with no case (#588) fix: e sync, compare paths with no case May 6, 2024
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think lower casing the path is right here as some filesystems are case sensitive, we probably just want to ensure path paths are fully normalized / resolved.

@andrewsml
Copy link
Author

@MarshallOfSound , Is it fine to make such a patch only for the Windows platform, like that?
76d4280

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to use a generic approach to filesystem path sensitivity

@MarshallOfSound
Copy link
Member

@andrewsml This PR is now ready to go but we require PRs to this (and some other Electron repos) to come with signed commits. Please set that up, or we can extract this PR into a new one with signed commits from a different auther

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e sync command fails due to git root mistmatch (Windows 10)
2 participants