Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow overriding DEVELOPER_DIR #435

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

codebytere
Copy link
Member

Allow users to override DEVELOPER_DIR.

Previously, if DEVELOPER_DIR was overridden, e load-xcode would try to switch it back every time.

@codebytere codebytere changed the title fix: allow overriding DEVELOPER_DIR fix: allow overriding DEVELOPER_DIR Nov 22, 2022
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we let DEVELOPER_DIR override our xcode? Or should we make people set something like ELECTRON_BUILD_TOOLS_DEVELOPER_DIR instead thus ensuring that CI / build systems that already set the standard dev-dir env var don't lose cache hits.

src/e-load-xcode.js Outdated Show resolved Hide resolved
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants