Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test rush change verify in ci job #1964

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
6 changes: 3 additions & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ jobs:
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
fetch-depth: 0
node-version: ${{ matrix.node-version }}

# TODO: enable `rush change -v` after rush migration is completed.
# - name: Verify Change Logs
# run: node common/scripts/install-run-rush.js change --verify --target-branch upstream/master
- name: Verify Change Logs
run: node common/scripts/install-run-rush.js change --verify

- name: Install
run: node common/scripts/install-run-rush.js install
Expand Down
4 changes: 2 additions & 2 deletions rush.json
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,12 @@
* your PR branch, and in this situation "rush change" will also automatically invoke "git fetch"
* to retrieve the latest activity for the remote main branch.
*/
// "url": "https://github.com/microsoft/rush-example",
"url": "https://github.com/electrode-io/electrode",
/**
* The default branch name. This tells "rush change" which remote branch to compare against.
* The default value is "main"
*/
// "defaultBranch": "main",
"defaultBranch": "master"
/**
* The default remote. This tells "rush change" which remote to compare against if the remote URL is
* not set or if a remote matching the provided remote URL is not found.
Expand Down