fix issues related to hmr, isomorphic loading, error reporting #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunvishnun
reviewed
Nov 29, 2022
| if (context.user.headEntries) { | ||
| headSplits.push(`<link rel="preload" href="${jsBundle}" as="script">`); | ||
| } | ||
| a.push(`<script src="${jsBundle}" async></script>`); | ||
| a.push(`<script src="${jsBundle}" async crossorigin="anonymous"></script>`); |
There was a problem hiding this comment.
Hi @ashuverma Thanks for changes.
Looks like this change is causing a test failure for should load bundles for the subapp - Error: Timeout of 2000ms exceeded. . Do you know what is going wrong ?
There was a problem hiding this comment.
Any examples where I can see this?
There was a problem hiding this comment.
Hi @ashuverma I just ran fun test in the root folder after merging master with this branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crossorigin="anonymous"to our scripts for error reporting. By default, error message will include onlyScript Error.Handle isomorphic loading e.g. images, css modules etc. during first load, the app will start before webpack finish compiling, so webpack will inform app that modules refreshed when they didn't. sets a one time flag to avoid refreshing when first start up, reset this one time flag only after isomorphic initialise is set.
mark
eager: truetemporarily to avoid shared eager. For long term, will be adding automated way via plugin.