Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create-container system tests on Windows #1734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix create-container system tests on Windows #1734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions system-tests/src/tests/misc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,15 @@ run(
{ expectedExitCode: 1 },
);

// Escape backslashes on Windows
const miniApp = `file:${
process.platform === 'win32'
? miniAppPath.replace(/\\/g, '\\\\')
: miniAppPath
}`;
// Container gen should be successful for the two following commands
run(`create-container --miniapps file:${miniAppPath} -p android`);
run(`create-container --miniapps file:${miniAppPath} -p ios --skipInstall`);
run(`create-container -m ${miniApp} -p android`);
run(`create-container -m ${miniApp} -p ios --skipInstall`);

// transform-container / publish-container should be successful
run(
Expand Down