fix: disable automatic fallback from SSL to non-SSL DB connection #1249
Conversation
`Postgrex` connector we're using now doesn't support fallback behavior like this, so we're disabling it for `epgsql` connections as well. This commit also fixes application of the default value for requiring SSL, which was erroneously "false" before. This means that if your DB doesn't support SSL, you need to explicitly specify it via `DATABASE_REQUIRE_SSL=false` env variable or `?sslmode=disable` in the connection string.
| {nil, nil} -> default_database_require_ssl | ||
| {nil, _} -> false |
There was a problem hiding this comment.
@alco match order made it so {nil, nil} case never matched before this change
|
@icehaunter |
|
@samwillis We can also change the default to NOT use ssl - so that we break setups expecting SSL but with a better explicit error on startup stating "hey set this flag probably" |
Postgrexconnector we're using now doesn't support fallback behavior like this, so we're disabling it forepgsqlconnections as well. This commit also fixes application of the default value for requiring SSL, which was erroneously "false" before. This means that if your DB doesn't support SSL, you need to explicitly specify it viaDATABASE_REQUIRE_SSL=falseenv variable or?sslmode=disablein the connection string.