feat!: server-driven unsubscribes #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-dp
reviewed
May 8, 2024
magnetised
requested changes
May 8, 2024
components/electric/lib/electric/satellite/client_reconnection_info.ex
Outdated
Show resolved
Hide resolved
components/electric/lib/electric/satellite/client_reconnection_info.ex
Outdated
Show resolved
Hide resolved
components/electric/lib/electric/satellite/client_reconnection_info.ex
Outdated
Show resolved
Hide resolved
components/electric/lib/electric/satellite/client_reconnection_info.ex
Outdated
Show resolved
Hide resolved
alco
reviewed
May 15, 2024
| CREATE TABLE #{Extension.client_unsub_points_table()} ( | ||
| client_id VARCHAR(64) NOT NULL, | ||
| subscription_id UUID NOT NULL, | ||
| wal_pos BIGINT NOT NULL, |
There was a problem hiding this comment.
I remember you raised an issue with this BIGINT type. It's not too late to change it here. Making the same change in the older migration can be done in a separate PR (I can handle that).
| Enum.map(moved_in_records, fn {id, record} -> {id, %Changes.NewRecord{record: record}} end) | ||
| # We're converting these records to a list of keys to query next layers on and building a fake-rooted graph. | ||
| # We're "rooting" the top layer of records so that `SentRowsGraph` functions know where to start traversal. | ||
| # It's important to get of that fake root later. |
There was a problem hiding this comment.
I'm not sure what this says. "Get off that fake root"? At what point later?
…e subscription ID
… we receive additional data. We filter the graph before saving it to additional data.
icehaunter
force-pushed
the
ilia/vax-1289-unsubscribe-handling
branch
from
ec9c694
to
bb7f5db
Compare
alco
pushed a commit
that referenced
this pull request
May 19, 2024
1. Adds new boundary messages to the protocol allowing the server to send a GONE batch - a set of messages for the client to know that those rows will not receive further updates after an unsubscribe call. 2. Server is the source of truth on which rows the client should have 3. Only while-online unsubscribes are possible 4. Client may reconnect at any point after sending the unsubscribe call and the server will adjust seen rows correctly and send a GONE batch if we don't believe the client had seen that -- see tests in `subscriptions_test.exs`. Missing is a public API for unsubscribes, that's in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscriptions_test.exs.Missing is a public API for unsubscribes, that's in the next PR.