fix(client_tests): Fix port collisions #1223
Conversation
| async start(): Promise<number> { | ||
| return new Promise((res) => { | ||
| this.httpServer.listen(() => { | ||
| const address = this.httpServer.address() |
There was a problem hiding this comment.
I would fetch the port directly on this line than there is no need for import { AddressInfo } from 'net' and for the cast on the line below.
There was a problem hiding this comment.
We could remove the cast, but then we would need to do (address() as any).port because it returns union type to take into account the different ways a server can be started.
There was a problem hiding this comment.
Right, nevermind. Let's keep it as is than, i prefer a cast to AddressInfo instead of any. Thanks for clarifying!
|
Thanks for reporting and fixing the potential port clash. All looks good to me, left a very minor comment that we could fix before i merge it. Thanks! |
|
@davidmartos96 can you add a changeset please, then i can merge :-) |
|
@kevin-dp Done! |
We found that the PG ports can collide in 2 of the tests. We've also included a way to automatically assign a port to the client tests http server, as we've sometimes found some flakiness with the fixed port being used already.
We found that the PG ports can collide in 2 of the tests.
We've also included a way to automatically assign a port to the client tests http server, as we've sometimes found some flakiness with the fixed port being used already.