fix(e2e_client): Fixes some typings in the e2e satellite client #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-dp
merged commit 483bcb5
into
electric-sql:kevindp/update-e2e-client
4 checks passed
kevin-dp
pushed a commit
that referenced
this pull request
May 14, 2024
I've looked into why Lux didn't catch this. It appears to be because it was matching the same string that appears async in stdout via a SatOpLog. So I've tweaked the expectation so that it is more strict. Another minor issue we found in the e2e client is the prisma definition for the enums table. We generate the Dart e2e client from the schema file, and the Enums model didn't include a `@@map`, so the generated table name was uppercase. But the e2e test creates the enums table as lowercase. There appears to be other typing issues in the client, but I'm not sure how to resolve.   cc @kevin-dp
kevin-dp
pushed a commit
that referenced
this pull request
May 16, 2024
I've looked into why Lux didn't catch this. It appears to be because it was matching the same string that appears async in stdout via a SatOpLog. So I've tweaked the expectation so that it is more strict. Another minor issue we found in the e2e client is the prisma definition for the enums table. We generate the Dart e2e client from the schema file, and the Enums model didn't include a `@@map`, so the generated table name was uppercase. But the e2e test creates the enums table as lowercase. There appears to be other typing issues in the client, but I'm not sure how to resolve.   cc @kevin-dp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've looked into why Lux didn't catch this. It appears to be because it was matching the same string that appears async in stdout via a SatOpLog. So I've tweaked the expectation so that it is more strict.
Another minor issue we found in the e2e client is the prisma definition for the enums table. We generate the Dart e2e client from the schema file, and the Enums model didn't include a
@@map, so the generated table name was uppercase. But the e2e test creates the enums table as lowercase.There appears to be other typing issues in the client, but I'm not sure how to resolve.
cc @kevin-dp