Create arctic-dex.toml #879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arctic-dex.toml
eherrerosj
suggested changes
Dec 24, 2023
|
Thank you, i fixed quotes in eco names and I also include it in the
proper sub_ecosystems.
Merry X-Mas :)
…On Sun, 24 Dec 2023 at 02:30, Enrique Herreros ***@***.***> wrote:
***@***.**** requested changes on this pull request.
You forgot quotes in eco names. Also, "Artic DEX" should be in the list of
sub_ecosystems of the compatible chains. id, you'll need to modify the
ethereum, starknet, zksync erc, aurora, etc tomls
—
Reply to this email directly, view it on GitHub
<#879 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDW3EDJGWB7KPIWRMTVYHATYK6AT5AVCNFSM6AAAAABBARTXGSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJVGUYTEMJVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
On sub_ecosystem push i receive some errors: *build*
<https://github.com/electric-capital/crypto-ecosystems/actions/runs/7312347390/job/19922812569>
The following actions uses node12 which is deprecated and will be forced to
run on node16: ***@***.*** For more info:
https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Can you please help me? Thank You.
On Sun, 24 Dec 2023 at 04:57, Mittie Studivant ***@***.***>
wrote:
… Thank you, i fixed quotes in eco names and I also include it in the
proper sub_ecosystems.
Merry X-Mas :)
On Sun, 24 Dec 2023 at 02:30, Enrique Herreros ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
>
> You forgot quotes in eco names. Also, "Artic DEX" should be in the list
> of sub_ecosystems of the compatible chains. id, you'll need to modify the
> ethereum, starknet, zksync erc, aurora, etc tomls
>
> —
> Reply to this email directly, view it on GitHub
> <#879 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BDW3EDJGWB7KPIWRMTVYHATYK6AT5AVCNFSM6AAAAABBARTXGSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJVGUYTEMJVGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***
> com>
>
|
jubos
requested changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arctic-dex.toml