New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zksync.toml with Vest Exchange #827
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments
@@ -4811,6 +4816,3 @@ url = "https://github.com/zy19900820/ethers" | |||
|
|||
[[repo]] | |||
url = "https://github.com/zycta/zycta-dapp" | |||
|
|||
[[repo]] | |||
url = "https://github.com/dappsheriff/zksync-contracts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we prefer to keep archived / missing repos because we have a persisted history that we can attribute to the parent ecosystem, please revert this deletion
@@ -4274,6 +4275,10 @@ missing = true | |||
[[repo]] | |||
url = "https://github.com/vertekfi/hardhat-template" | |||
|
|||
[[repo]] | |||
url = "https://github.com/VestLabs/papers/blob/main/zkRisk/zkRisk.pdf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a correct repo url
@@ -25,6 +25,7 @@ sub_ecosystems = [ | |||
"SyncSwap", | |||
"TrueFi Engineering (Ethworks)", | |||
"Uniswap", | |||
"Vest Exchange", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to create a new ecosystem for "Vest Exchange". For that, you need to create a new toml file like vest-exchange.toml with title "Vest Exchange" and add the org in it (https://github.com/VestLabs). This is assuming VestLabs dedicates most of it efforts to work on a projects(s) in ZKSync. Otherwise, just place here the specific repos that contribute to ZKSync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see enrique's comments above
No description provided.