update aptos.toml

[hhuang728]

add new repo without depulicated repo in origianl toml file

[hhuang728]

Hey @jubos , could you please help to review about PR?

Also I have a question about the sub-ecosystem developer/commit calculation? For example, pancakeswap is the sub ecosystem for aptos. But when EC count commits or developers for aptos, did EC count all commits from pancakeswap repos? Since pancakeswap is the sub-ecosystem for many chains, I am a little bit confuse about the calculation logic. Thanks!

[hhuang728]

Hey @jubos , could you please help to review this PR? Thank you!

[jubos]

@hhuang728, thank you for the PR.

As of now, this casts a bit too wide of a net. There are a lot of developer forks of aptos-core with no changes, so we tend not to add those because they can pollute the taxonomy.

Can you scope this change and add some of the easier ones (e.g. repos that have aptos in the name or have many mentions of Aptos) and then do a separate PR for some of the sub ecosystem additions like Wormhole or the Arweave related repos that may or may not be Aptos related?

[hhuang728]

Hi @jubos , thanks for your reply!
just want to clarify more detail here:

1. would you like us to remove forked repo from aptos-core?
2. for 'add some of the easier ones (e.g. repos that have aptos in the name or have many mentions of Aptos)', 'have many mentions of Aptos', could you please let me know how to find 'mentions' here?
3. a separate PR for some of the sub ecosystem.
   (1)would you like to put repos which belong to sub-ecosystem to sub ecosystem toml, such as wormhole-foundation/relayer-network-dashboard will be put in wormhole.toml?
   (2)how to deal with the repo name which including sub ecosystem name, such as ciphermarco/wormhole or gabzim/wormhole-relayer?

[jubos]

Hi @jubos , thanks for your reply! just want to clarify more detail here:

1. would you like us to remove forked repo from aptos-core?

Yes, unless they have significant commits that are different from aptos-core.

2. for _'add some of the easier ones (e.g. repos that have aptos in the name or have many mentions of Aptos)'_, 'have many mentions of Aptos', could you please let me know how to find 'mentions' here?

You can do a grep of aptos in the codebase or in the README.md. Some of the repos that might be pulling in a transitive dependency on a project that has aptos mentioned somewhere would have a very tenuous connection to Aptos and probably shouldn't be included.

3. a separate PR for some of the sub ecosystem.
   (1)would you like to put repos which belong to sub-ecosystem to sub ecosystem toml, such as wormhole-foundation/relayer-network-dashboard will be put in wormhole.toml?
   (2)how to deal with the repo name which including sub ecosystem name, such as ciphermarco/wormhole or gabzim/wormhole-relayer?

Those should be added into Wormhole and Wormhole can be a sub ecosystem of Aptos instead of adding them directly to the aptos.toml file.

[hhuang728]

Hi @jubos, Thanks for providing detail feedback. I just updated the repo list based on above discussion. However there is Error: Process completed with exit code 2 in the validation check. Could you please help to take a look? Thanks!

[jubos]

If you can sort the repos that you are adding, it will make reviewing a lot easier. This was added recently as part of the validation step.

[hhuang728]

Hi @jubos ,got it. just submitted based on all previous feedback. Please help to review. Thank you!

[hhuang728]

Hey @jubos , thanks for all of your previous help!
could you please help review this updated pr based on previous guideline?