New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more to the Stellar ecosystem. #1119
base: master
Are you sure you want to change the base?
Add more to the Stellar ecosystem. #1119
Conversation
Hey, there, @jubos! Thanks for the feedback. Yeah, I can make a PR that only includes the "obvious" ones. I'll take a look over all the additions, and give a second thought. Are there specific additions here you can share that might not fit with the Stellar ecosystem? Maybe I've been thinking about it wrong, too. In my head, if a project/repo was "building on" Stellar, then I added it to the list. I was even considering that to be true in the event that they were incorporating Stellar as a secondary/tertiary/etc. chain. Perhaps that was over-zealous? Is the definition of "attributable" more about which chain the project originates on? I may have gotten confused with the recent EC updates to include multi-chain devs/projects. Thanks again! |
I took a first stab at reverting any "questionable" additions. I took most of these repos/orgs from some of our internal grant applications. Maybe some are not as far along in the process of integrating Stellar, which would likely mean they're not yet right to include in our ecosystem? It might also help to know that "Soroban" is the name of the smart contracts platform that was build for inclusion within the Stellar network (not as an L2, but has been included in the core network now). Anywhere you see "soroban," you can pretty much substitute the word Stellar, tbh. Let me know if this covers all the "debatable" additions. Or, if there are still some more that aren't as clear-cut as you'd like. Thanks! |
@jubos Any thoughts on these changes? |
@jubos Sorry to bug you again. Any suggestions or changes you'd like to see here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these additions. Overall look good, but let's move the orgs to specific sub ecosystems and then add them to Stellar. This allows for more flexibility.
data/ecosystems/s/stellar.toml
Outdated
"https://github.com/CommuniDAO", | ||
"https://github.com/Creit-Tech", | ||
"https://github.com/fairxio", | ||
"https://github.com/fluxitystellar", | ||
"https://github.com/GladiusClub", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move these github orgs to sub ecosystems since it is more flexible in the future especially if the orgs work in multiple ecosystems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jubos I can do that, for sure! Couple questions first:
- Are there some "guidelines" you all like use to determine if something should be a sub-ecosystem, as opposed to just a
github_organization
? - Should I move all of the github orgs I've got in this PR, or just some of them?
- More generally speaking, does EC prefer to have sub-ecosystems set up rather than github orgs?
@jubos I've gone ahead and changed most of the added github orgs to distinct sub-ecosystems. I left some of the github orgs that are particularly Stellar-specific, and it doesn't seem (to me at least) that there will be a high likelihood of becoming multi-chain orgs. Of course, I'm more than happy to change those to sub-ecosystems, too, if you'd like. Thanks! |
Adding lots of projects, repos, and organizations to the Stellar ecosystem.
It seems that (generally) these toml files are kept in alphabetical order, so I've tried to keep that convention going. If that's incorrect, I'm happy to make any changes necessary.