Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for any scrolling container (window or other) #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgon
Copy link

@rgon rgon commented Oct 24, 2022

Adds support to animate on any container's scroll property. Allows

I would've rather chosen the ES6 class constructor to implement it, but I kept the global variable logic the same. The main change is I'm savingscrollContainers which themselves have instances instead of instances themselves (so we can iterate through the containers to see which have changed).

resolves #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set scrolling element to something other than the window
1 participant