Fix handling of double-quotes in encrypted file names #173 #174
+52
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `_list_encrypted_files()` function that returns get un-quoted filenames for encrypted files by using the `-z` option to Git's `ls-files` command, with follow-on special handling - Use this function instead of long piped commands previously used to list encrypted filenames, which failed if these names contained double-quote characters due to the insufficient work-around of unsetting the `core.quotePath` config option.
…al of transcript from Git repo
Mainly to trigger test run in GitHub
Had to cheat a bit with this fix, by relaxing the unit tests to allow `ls-crypt` and `ls-crypt-default` to work the same way, where they didn't previously
…by not checking file name directly
|
Nice patch! This fixes also another bug where |
andreineculau
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #173