Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TS v4 #73924

Merged
merged 55 commits into from
Aug 27, 2020
Merged

Update to TS v4 #73924

merged 55 commits into from
Aug 27, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Jul 31, 2020 •
edited

Summary

Changes https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/
Closes: #71932
Preparatory work for #72280

Known problems

  • delete property reports an error if the property is not optional. It's okay to mute such errors in tests. In other places I did my best to fix types, remaining issues could be addressed by code owners (in follow-ups)
  • useKibana interface might need to be changed to separate required core service and optional plugin API. For now, I declare all the required services manually.

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 31, 2020
@mshustov mshustov added this to Pending Review in kibana-core [DEPRECATED] via automation Aug 2, 2020
@mshustov mshustov mentioned this pull request Aug 3, 2020
Merged
1 task
@mshustov mshustov self-assigned this Aug 4, 2020
@mshustov
Copy link
Contributor Author

mshustov commented Aug 5, 2020 •
edited

@elastic/kibana-telemetry I need your help to fix a failed telemetry test

@afharo
Copy link
Member

afharo commented Aug 5, 2020

@restrry ACK! I'll take a look at it tomorrow morning if that's OK.

@joshdover joshdover mentioned this pull request Aug 6, 2020
Closed
3 tasks
kertal
kertal approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KibanaApp Code LGTM 👍

@mshustov
Copy link
Contributor Author

@afharo Telemetry tests are failing again. Would you mind taking a look, please?

@mshustov mshustov requested review from a team as code owners August 26, 2020 19:00
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Aug 26, 2020
kindsun
kindsun approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maps changes lgtm!

  • code review

poffdeluxe
poffdeluxe approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes lgtm

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
enterpriseSearch 350.3KB +2.0B 350.3KB
infra 3.6MB -236.0B 3.6MB
ml 8.2MB +84.0B 8.2MB
security 1.0MB -252.0B 1.0MB
securitySolution 9.5MB -648.0B 9.5MB
transform 704.2KB -254.0B 704.5KB
uptime 1.6MB +12.0B 1.6MB
visTypeVega 1.4MB +228.0B 1.4MB
total -1.0KB

page load bundle size

id value diff baseline
upgradeAssistant 64.7KB +2.0B 64.7KB

oss distributable file count

id value diff baseline
total 26251 -111 26362

distributable file count

id value diff baseline
total 53124 -111 53235

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 37ec1e1 into elastic:master Aug 27, 2020
kibana-core [DEPRECATED] automation moved this from Pending Review to Done (7.10) Aug 27, 2020
@mshustov mshustov mentioned this pull request Aug 27, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request Aug 27, 2020
@mshustov
Update to TS v4 (elastic#73924)
5282748 
* bump ts to v4

* MOAR RAM

* fix type errors for OSS

* first pass on x-pack errors

* second pass on x-pack type errors

* 3rd pass on x-pack type-errors

* mute errors if complex cases

* don't delete if spread suffices

* mute other complex cases

* make User fields optional

* fix optional types

* fix tests

* fix typings for time_range

* fix type errors in x-pack/tests

* rebuild kbn-pm

* remove leftovers from master update

* fix alert tests

* [Telemetry Checker] TS4 Fixes

* bump to 4.0.1-rc

* fix new errors in master

* bump typescript-eslint to version supporting TS v4 syntax

* fix merge commit errors

* update to the stable TS version 4.0.2

* bump ts-eslint to version supporting ts v4

* fix typo

* fix type errors after merge

* update ts in another new package.json

* TEMP: remove me

* Revert "TEMP: remove me"

This reverts commit dc0fc3b.

* [Telemetry] Update snapshot for new TS4 SyntaxKind

* bump prettier to support TS v4 syntax

* fix prettier rules

* last style change

* fix new type errors

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
# Conflicts:
#	packages/kbn-i18n/package.json
#	x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx
#	x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx
mshustov added a commit that referenced this pull request Aug 27, 2020
@mshustov
Update to TS v4 (#73924) (#76069)
1c1dbe5 
* bump ts to v4

* MOAR RAM

* fix type errors for OSS

* first pass on x-pack errors

* second pass on x-pack type errors

* 3rd pass on x-pack type-errors

* mute errors if complex cases

* don't delete if spread suffices

* mute other complex cases

* make User fields optional

* fix optional types

* fix tests

* fix typings for time_range

* fix type errors in x-pack/tests

* rebuild kbn-pm

* remove leftovers from master update

* fix alert tests

* [Telemetry Checker] TS4 Fixes

* bump to 4.0.1-rc

* fix new errors in master

* bump typescript-eslint to version supporting TS v4 syntax

* fix merge commit errors

* update to the stable TS version 4.0.2

* bump ts-eslint to version supporting ts v4

* fix typo

* fix type errors after merge

* update ts in another new package.json

* TEMP: remove me

* Revert "TEMP: remove me"

This reverts commit dc0fc3b.

* [Telemetry] Update snapshot for new TS4 SyntaxKind

* bump prettier to support TS v4 syntax

* fix prettier rules

* last style change

* fix new type errors

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
# Conflicts:
#	packages/kbn-i18n/package.json
#	x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx
#	x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx
@mshustov mshustov deleted the issue-71932-ts-4 branch August 27, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfsiii jfsiii jfsiii left review comments

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@oatkiller oatkiller oatkiller approved these changes

@justinkambic justinkambic justinkambic approved these changes

@Bamieh Bamieh Bamieh approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@mikecote mikecote mikecote approved these changes

@legrego legrego legrego approved these changes

@kindsun kindsun kindsun approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@spalger spalger spalger approved these changes

@weltenwort weltenwort weltenwort approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@rylnd rylnd rylnd approved these changes

@kertal kertal kertal approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

@mattkime mattkime mattkime approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@skh skh skh approved these changes

Assignees

@mshustov mshustov

Labels
backported chore Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0
Projects
kibana-core [DEPRECATED]
Done (7.13)
Kibana developer experience [NOTICE T...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to TypeScript 4.0