Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps] rules runs recovered actions without ever running active actions #183646

Merged
merged 5 commits into from
May 20, 2024
Merged

[ResponseOps] rules runs recovered actions without ever running active actions #183646

merged 5 commits into from
May 20, 2024
+185 −5

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented May 16, 2024 •
edited

Resolves #182888

Summary

This PR resolves a bug where rules will run the recovery actions for a delayed active alert.

Checklist

To verify

  • Create a rule and set the alert after x consecutive matches to be greater than 1. It may be helpful for testing to include recovered and active actions.
  • Make sure the delayed active alert recovers before hitting the consecutive matches threshold.
  • Verify that the rule does not send a recovery action and does not show a recovered alert in the rule run table.

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi changed the title Updating to handle recovered alerts [ResponseOps] rules runs recovered actions without ever running active actions May 16, 2024
@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:fix v8.15.0 labels May 16, 2024
@doakalexi
Copy link
Contributor Author

/ci

@doakalexi
Copy link
Contributor Author

/ci

@doakalexi doakalexi marked this pull request as ready for review May 16, 2024 18:36
@doakalexi doakalexi requested review from a team as code owners May 16, 2024 18:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

umbopepato
umbopepato approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@umbopepato umbopepato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, LGTM!

pmuellr
pmuellr approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi merged commit 0f159b7 into elastic:main May 20, 2024
35 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@umbopepato umbopepato umbopepato approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps] rules runs recovered actions without ever running active actions
6 participants
@doakalexi @elasticmachine @kibana-ci @pmuellr @umbopepato @kibanamachine