Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] AI Assistant, replace LLM with SimpleChatModel #182041

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

stephmilovic
Copy link
Contributor

Summary

  1. Replaces the LLM model and chat-conversational-react-description agent with the SimpleChatModel model and structured-chat-zero-shot-react-description agent for non-streaming AI Assistant requests.
  2. Updates ESQLKnowledgeBaseTool from DynamicTool to DynamicStructuredTool

Here are some datasets using the updated ESQLKnowledgeBaseTool

SimpleChatModel - Sonnet
SimpleChatModel - Azure
ChatOpenAI - Azure

Still To Do

  1. Update the AlertCountsTool and OpenAndAcknowledgedAlertsTool tools from DynamicTool to DynamicStructuredTool
  2. Update the other usages of ActionsClientLlm with ActionsClientSimpleChatModel (post_evaluate and post_attack_discovery)
  3. Experiment with updating the AttackDiscoveryTool to DynamicStructuredTool

May do the attack discovery stuff in a separate PR depending on what @andrew-goldstein thinks.

@stephmilovic stephmilovic added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Security Assistant Security Assistant Team:Security Generative AI Security Generative AI v8.15.0 labels Apr 29, 2024
memory,
verbose: false,
returnIntermediateSteps: false,
handleParsingErrors: 'Try again, paying close attention to the allowed tool input',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleParsingErrors can also be a function, so I put logs in here while developing. It was not hit once I added the agentArgs. However when I was hitting it, it did help to get the agent back on track so I think I should leave it. Here is an example of a run where it was hit: https://smith.langchain.com/public/910b7739-cd9a-401b-9db0-fe8438ff53e5/r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Security Assistant Security Assistant release_note:enhancement Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant