New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Semantic Text UI] Handle the case when the model is not yet downloaded #182040
[Semantic Text UI] Handle the case when the model is not yet downloaded #182040
Conversation
@elastic/kibana-management It would be great if I can get a review for this PR. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nitpick but generally looks good :)
...ngs_editor/components/document_fields/fields/create_field/semantic_text/use_semantic_text.ts
Outdated
Show resolved
Hide resolved
...ngs_editor/components/document_fields/fields/create_field/semantic_text/use_semantic_text.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for addressing this use case, @saikatsarkar056!
After testing the changes locally, I'd just want to confirm that the UX with the modal blocking the user from saving the mappings is the best choice. If I understand correctly, the modal will now wait until the model is downloaded and deployed. That could take a really long time. Should we consider starting the download and deployment of the model in the background instead?
88b1064
to
d02d315
Compare
@yuliacech Please notice this code-block. The model download and deployment are occurring in the background. Only the check to determine if a model has already been downloaded is performed asynchronously, which is quite fast. Furthermore, I've relocated the CreateInferenceEndpoint block to its own function, allowing us to call it after the model has been downloaded and deployed. The modifications in this pull request indicate that the model download, model deployment, and CreateInferenceEndpoint processes occur one-after-another in the background. |
@yuliacech Thank you for the feedback. Can you please review this PR once again? |
d67f89f
to
9c5cbbc
Compare
9c5cbbc
to
55cf7e1
Compare
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML changes LGTM
When the trained model is not yet downloaded, it can't be deployed. This PR has covered the following:
How to test the changes locally
./gradlew :run -Drun.license_type=trial
yarn start