[AppEx-SharedUX] Remove toMountPoint parameter from TableListViewKibanaProvider #182030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
sharedux/clean-up-table-list-view-kibana-provider-props
branch
from
3b592ad
to
0b42eb1
Compare
tsullivan
force-pushed
the
sharedux/clean-up-table-list-view-kibana-provider-props
branch
from
eff1e14
to
b930894
Compare
|
/ci |
tsullivan
changed the title
tsullivan
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
cqliu1
approved these changes
Apr 29, 2024
pgayvallet
approved these changes
Apr 30, 2024
Dosant
approved these changes
Apr 30, 2024
| @@ -26,6 +26,8 @@ | |||
| "@kbn/shared-ux-link-redirect-app", | |||
| "@kbn/test-jest-helpers", | |||
| "@kbn/content-management-table-list-view-common", | |||
| "@kbn/core", | |||
There was a problem hiding this comment.
probably nit: I prefer to depend on specific packages types in packages instead of depending on the whole core
…up-table-list-view-kibana-provider-props # Conflicts: # packages/content-management/table_list_view_table/src/services.tsx # packages/content-management/table_list_view_table/tsconfig.json # src/plugins/dashboard/public/dashboard_listing/dashboard_listing_table.tsx
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
tsullivan
deleted the
sharedux/clean-up-table-list-view-kibana-provider-props
branch
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
…naProvider (elastic#182030) ## Summary The `toMountPoint` module from `@kbn/kibana-react-plugin/public` is deprecated. Many areas of code need to include it and provide it as a required prop of `TableListViewKibanaProvider`. This PR resolves that: it shouldn't need to be a required prop anywhere, since it is a stateless component and can be included as-needed. This PR also updates the inclusion of `toMountPoint` to use the non-deprecated source, which is `@kbn/react-kibana-mount`. As a side effect of that, some consumers need to update the `core` property being passed, to ensure it includes the `analytics`, `i18n` and `theme` services. ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
toMountPointmodule from@kbn/kibana-react-plugin/publicis deprecated. Many areas of code need to include it and provide it as a required prop ofTableListViewKibanaProvider. This PR resolves that: it shouldn't need to be a required prop anywhere, since it is a stateless component and can be included as-needed.This PR also updates the inclusion of
toMountPointto use the non-deprecated source, which is@kbn/react-kibana-mount. As a side effect of that, some consumers need to update thecoreproperty being passed, to ensure it includes theanalytics,i18nandthemeservices.Checklist
Delete any items that are not applicable to this PR.