[Fleet] Fix add Fleet server scenarios with subfeatures enabled #182015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nchaulet
commented
Apr 29, 2024
nchaulet
added
release_note:skip
nchaulet
force-pushed
the
fix-add-fleet-server-subfeatures
branch
from
7a460c6
to
105ac55
Compare
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
commented
Apr 29, 2024
| @@ -159,7 +173,7 @@ export const registerRoutes = (router: FleetAuthzRouter) => { | |||
| .post({ | |||
| path: APP_API_ROUTES.GENERATE_SERVICE_TOKEN_PATTERN_DEPRECATED, | |||
| fleetAuthz: { | |||
| fleet: { all: true }, | |||
| fleet: { allAgents: true }, | |||
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
added
v8.15.0
backport:skip
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #180661
Resolve #181757
Fix a few bug to note show invalid action when user try to add a fleet server without all the needed permissions, sees UI changes for details.
UI Changes
Add Fleet server flyout
If the user do not have
manage_service_accounthe could not generate service token and cannot enroll a fleet server.If a user cannot create policies it will not be able to click on generate fleet server policy
Integration policy table
Disable add agent if user cannot add Fleet server (no agents: all, settings: all(
Tests
Manual Try to add fleet server with and without
manage_service_account