[SharedUX/React render] prevent double-nested EuiProvider #182005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
commented
Apr 29, 2024
tsullivan
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
clintandrewhall
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Great work. Might wait for @cee-chen to weigh in, but I think it's ok to address later/async.
| import type { I18nStart } from '@kbn/core-i18n-browser'; | ||
|
|
||
| // @ts-expect-error EUI exports this component internally, but Kibana isn't picking it up its types | ||
| import { useIsNestedEuiProvider } from '@elastic/eui/lib/components/provider/nested'; |
There was a problem hiding this comment.
@cee-chen Can this be something addressed in a future EUI release? Or is this a mistake somehow, (I don't see how).
There was a problem hiding this comment.
Not a mistake, this has been done other places in Kibana as well (whenever devs reach into @elastic/eui/lib). TBH I'm not 100% sure it's solvable on just the EUI level - I think it's a weird factor of how Kibana optimizes shared dependencies and its bazel pipeline. We might need to loop in KibanaOps for this as I'm not too sure why this happens either - I do believe it used to work at some point.
| @@ -11,9 +11,9 @@ import useObservable from 'react-use/lib/useObservable'; | |||
|
|
|||
| import { EuiThemeProvider, EuiThemeProviderProps } from '@elastic/eui'; | |||
|
|
|||
| // @ts-ignore EUI exports this component internally, but Kibana isn't picking it up its types | |||
| // @ts-expect-error EUI exports this component internally, but Kibana isn't picking it up its types | |||
jbudz
approved these changes
Apr 29, 2024
jbudz
reviewed
Apr 29, 2024
| // @ts-expect-error EUI exports this component internally, but Kibana isn't picking it up its types | ||
| import { useIsNestedEuiProvider } from '@elastic/eui/lib/components/provider/nested'; | ||
| // @ts-expect-error EUI exports this component internally, but Kibana isn't picking it up its types | ||
| import { emitEuiProviderWarning } from '@elastic/eui/lib/services/theme/warning'; |
There was a problem hiding this comment.
Did we look into adding this to kbn-ui-shared-deps?
There was a problem hiding this comment.
Thanks for the suggestion. I am looking into it now: dd3f12a
There was a problem hiding this comment.
TIL this is an option - going to bookmark this for future reference 👀
This reverts commit 0ec663b.
|
Broken by dd3f12a... still working on this.
|
|
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
…2005) ## Summary Addresses extraneous errors discovered in elastic#180819 --------- Co-authored-by: Clint Andrew Hall <clint@clintandrewhall.com> Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses extraneous errors discovered in #180819