[Dev console] Fix some issues with AutoComplete #182002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
kderusso
added
the
release_note:skip
ioanatia
approved these changes
Apr 29, 2024
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
sabarasaba
approved these changes
Apr 30, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 30, 2024
Resolves elastic#181618 by adding delete by query AutoComplete for the query. Here's what it looks like now: https://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1 Also fixes a syntax issue with rule query AutoComplete where we added an extra `query` that would result in a syntax error. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 5814f2e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 30, 2024
…2123) # Backport This will backport the following commits from `main` to `8.14`: - [[Dev console] Fix some issues with AutoComplete (#182002)](#182002) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kathleen DeRusso","email":"kathleen.derusso@elastic.co"},"sourceCommit":{"committedDate":"2024-04-30T13:17:01Z","message":"[Dev console] Fix some issues with AutoComplete (#182002)\n\nResolves #181618 by adding\r\ndelete by query AutoComplete for the query.\r\n\r\nHere's what it looks like now: \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1\r\n\r\nAlso fixes a syntax issue with rule query AutoComplete where we added an\r\nextra `query` that would result in a syntax error.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5814f2e0cea6a2ad797c10105badbbc313635bdd","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.14.0","v8.15.0"],"title":"[Dev console] Fix some issues with AutoComplete","number":182002,"url":"#182002 console] Fix some issues with AutoComplete (#182002)\n\nResolves #181618 by adding\r\ndelete by query AutoComplete for the query.\r\n\r\nHere's what it looks like now: \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1\r\n\r\nAlso fixes a syntax issue with rule query AutoComplete where we added an\r\nextra `query` that would result in a syntax error.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5814f2e0cea6a2ad797c10105badbbc313635bdd"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182002 console] Fix some issues with AutoComplete (#182002)\n\nResolves #181618 by adding\r\ndelete by query AutoComplete for the query.\r\n\r\nHere's what it looks like now: \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1\r\n\r\nAlso fixes a syntax issue with rule query AutoComplete where we added an\r\nextra `query` that would result in a syntax error.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5814f2e0cea6a2ad797c10105badbbc313635bdd"}}]}] BACKPORT--> Co-authored-by: Kathleen DeRusso <kathleen.derusso@elastic.co>
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
Resolves elastic#181618 by adding delete by query AutoComplete for the query. Here's what it looks like now: https://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1 Also fixes a syntax issue with rule query AutoComplete where we added an extra `query` that would result in a syntax error. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #181618 by adding delete by query AutoComplete for the query.
Here's what it looks like now:
Screen.Recording.2024-04-29.at.11.41.43.AM.mov
Also fixes a syntax issue with rule query AutoComplete where we added an extra
querythat would result in a syntax error.