[ML] Add AD job validation UI tests #179358

wayneseymour · 2024-03-25T15:15:55Z

Summary

Add job wizard validation suite
Add job wizard model change annotation recommendation callout test subject
Add job wizard model time picker test subject using popperProps
Add test subjects for two steps: Time Range and Job Details
Add more methods to job wizard common service

- Add job wizard validation suite - Add job wizard model change annotation recommendation callout test subject - Add job wizard model time picker test subject within a div, as the EUI documents are incorrect about data-test-subjs for this component - Add test subjects for two steps: Time Range and Job Details - Add more methods to job wizard common service

elasticmachine · 2024-03-25T15:16:06Z

Pinging @elastic/ml-ui (:ml)

…dation-ui-tests

Use selectors over visible text. Change assertions based on lessons learned from previous code reviews.

…dation-ui-tests

x-pack/plugins/ml/public/application/components/callout/callout.tsx

darnautov · 2024-03-28T13:09:16Z

x-pack/plugins/ml/public/application/jobs/new_job/common/components/time_range_picker.tsx

-              dateFormat={dateFormat}
-              minDate={startMoment}
-            />
+            <div data-test-subj="mlJobWizardDatePickerRangeEndDate">


https://eui.elastic.co/#/forms/date-picker supports data-test-subj, hence you do not need a wrapper.

I tried it, following the docs per our zoom, but it did not work. I'll try again though!

@darnautov perhaps a longer timeout?

FYI adding a div wrapper also braked styles.

@wayneseymour you set a data-test-subj prop in the wrong place. It should be for EuiDatePickerRange, not endDateControl

Ah ok, so many dates lol. Thanks @darnautov 🙉

yeah I dont think either of those work, so I've switched it to a span

no more span!
1f9611a

x-pack/plugins/ml/public/application/jobs/new_job/pages/new_job/wizard_horizontal_steps.tsx

darnautov · 2024-03-28T13:23:40Z

x-pack/test/functional/services/ml/job_wizard_common.ts

+    async getAnnotationSwitchCheckedState(): Promise<boolean> {
+      const subj = 'mlJobWizardSwitchAnnotations';
+      const isSelected = await testSubjects.getAttribute(subj, 'aria-checked');
+      return isSelected === 'true';
+    },
+
+    async getAnnotationsSwitchCheckedState(expectedValue: boolean) {
+      const actualCheckedState = await this.getAnnotationSwitchCheckedState();
+      expect(actualCheckedState).to.eql(
+        expectedValue,
+        `Expected annotations switch to be '${expectedValue ? 'enabled' : 'disabled'}' (got '${
+          actualCheckedState ? 'enabled' : 'disabled'
+        }')`
+      );
+    },
+
+    async toggleAnnotationSwitch(toggle: boolean) {
+      const subj = 'mlJobWizardSwitchAnnotations';
+      if ((await this.getAnnotationSwitchCheckedState()) !== toggle) {
+        await retry.tryForTime(5 * 1000, async () => {
+          await testSubjects.clickWhenNotDisabledWithoutRetry(subj);
+          await this.getAnnotationSwitchCheckedState();
+        });
+      }
+    },


We have a similar code snippet copy-pasted in so many places. Can you please create reusable methods in x-pack/test/functional/services/ml/common_ui.ts?

getSwitchChechedState(testSubj: string)

toggleSwitchIfNeeded(testSubj: string, targetState: boolean)

wayneseymour@6602b29

x-pack/test/functional/services/ml/job_wizard_common.ts

darnautov · 2024-03-28T13:28:53Z

x-pack/test/functional/apps/ml/anomaly_detection_jobs/job_wizard_validation.ts

+    },
+  ];
+
+  describe('job wizard validation', function () {


I reckon you should not create a dedicated test suite for that, and go through all the wizard steps again.
We already have multiple tests for job wizards. Simply add a test suite to assert job validation.

For instance in the multi-metric wizards tests:

await ml.testExecution.logTestStep('job creation displays the validation step'); await ml.jobWizardCommon.advanceToValidationSection();

Add your assertion after these lines

@darnautov One of the reasons I created this is not have a nested suite.
I'll see if I can fit these in elsewhere without a nested suite.

x-pack/test/functional/services/ml/job_wizard_common.ts

…dation-ui-tests

Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>

…our/kibana into ml-add-job-validation-ui-tests

…t.tsx Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>

…our/kibana into ml-add-job-validation-ui-tests

wayneseymour · 2024-05-22T08:32:56Z

@elasticmachine merge upstream

wayneseymour · 2024-05-23T16:01:56Z

@elasticmachine merge upstream

wayneseymour · 2024-05-24T08:28:00Z

@elasticmachine merge upstream

pheyos

Looks good overall, left a few suggestions.

x-pack/test/functional/services/ml/common_ui.ts

x-pack/test/functional/services/ml/job_wizard_common.ts

x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_metric_job.ts

…etric_job.ts Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Co-authored-by: Robert Oskamp <traeluki@gmail.com>

wayneseymour · 2024-05-24T15:09:46Z

@elasticmachine merge upstream

x-pack/test/functional/services/ml/job_wizard_common.ts

…our/kibana into ml-add-job-validation-ui-tests

wayneseymour · 2024-05-27T08:28:06Z

@elasticmachine merge upstream

kibana-ci · 2024-05-27T09:55:34Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 31f5136

Failed CI Steps

FTR Configs #4

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	4.1MB	4.1MB	+619.0B

History

💚 Build #212107 succeeded 528d151
💔 Build #212033 failed dd28646
💔 Build #212001 failed 0355263
💔 Build #211913 failed afa90d7
💛 Build #211807 was flaky ab3b025
💚 Build #211423 succeeded b8c45d7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

pheyos

LGTM

## Summary - Add job wizard validation suite - Add job wizard model change annotation recommendation callout test subject - Add job wizard model time picker test subject using `popperProps` - Add test subjects for two steps: Time Range and Job Details - Add more methods to job wizard common service --------- Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Robert Oskamp <traeluki@gmail.com>

wayneseymour added :ml release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage backport:skip This commit does not require backporting labels Mar 25, 2024

wayneseymour self-assigned this Mar 25, 2024

wayneseymour marked this pull request as ready for review March 25, 2024 15:16

wayneseymour requested a review from a team as a code owner March 25, 2024 15:16

wayneseymour requested a review from pheyos March 25, 2024 15:16

wayneseymour added 2 commits March 27, 2024 09:42

Merge branch 'main' of github.com:elastic/kibana into ml-add-job-vali…

215d757

…dation-ui-tests

Merge branch 'main' of github.com:elastic/kibana into ml-add-job-vali…

49c3901

…dation-ui-tests

peteharverson requested a review from darnautov March 27, 2024 15:11

wayneseymour added 2 commits March 27, 2024 15:49

Truncate test subj for validation callout, from msg contents.

057da93

Use selectors over visible text. Change assertions based on lessons learned from previous code reviews.

Merge branch 'main' of github.com:elastic/kibana into ml-add-job-vali…

2667c93

…dation-ui-tests

darnautov reviewed Mar 28, 2024

View reviewed changes

wayneseymour and others added 14 commits April 1, 2024 11:06

Merge branch 'main' of github.com:elastic/kibana into ml-add-job-vali…

d5bc5a5

…dation-ui-tests

Graft it block to existing suite, per cr.

433aad8

Graft next it block to exisiting suite, per cr.

21c1f50

Graft next it block to existing suite.

f1bb227

Drop new suite.

30a59c6

Update x-pack/test/functional/services/ml/job_wizard_common.ts

affd426

Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>

Merge branch 'ml-add-job-validation-ui-tests' of github.com:wayneseym…

9dc3b15

…our/kibana into ml-add-job-validation-ui-tests

Change symbol name, per cr.

f5cd43b

More cr fixups

6602b29

Update x-pack/plugins/ml/public/application/components/callout/callou…

ef73e43

…t.tsx Co-authored-by: Dima Arnautov <arnautov.dima@gmail.com>

Merge branch 'ml-add-job-validation-ui-tests' of github.com:wayneseym…

e1e75d1

…our/kibana into ml-add-job-validation-ui-tests

Change for test subjs, per cr.

bdd577b

Fixup assertions, per cr.

57ed9df

assert test subj and text

b33540c

Merge branch 'main' into ml-add-job-validation-ui-tests

b8c45d7

Merge branch 'main' into ml-add-job-validation-ui-tests

ab3b025

Merge branch 'main' into ml-add-job-validation-ui-tests

afa90d7

pheyos reviewed May 24, 2024

View reviewed changes

wayneseymour and others added 10 commits May 24, 2024 13:09

Update x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_m…

e53e9d9

…etric_job.ts Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_m…

a1fe7e4

…etric_job.ts Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_m…

0f62a46

…etric_job.ts Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_m…

d8edc00

…etric_job.ts Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_m…

9d7a2a2

…etric_job.ts Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_m…

a0e5557

…etric_job.ts Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/services/ml/job_wizard_common.ts

4be34ab

Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/services/ml/job_wizard_common.ts

820e96c

Co-authored-by: Robert Oskamp <traeluki@gmail.com>

Update x-pack/test/functional/services/ml/common_ui.ts

0355263

Co-authored-by: Robert Oskamp <traeluki@gmail.com>

fixups per cr

dd28646

Merge branch 'main' into ml-add-job-validation-ui-tests

1ee9dee

pheyos reviewed May 24, 2024

View reviewed changes

x-pack/test/functional/services/ml/job_wizard_common.ts Show resolved Hide resolved

wayneseymour added 2 commits May 24, 2024 16:35

add assertion per cr

d4bea26

Merge branch 'ml-add-job-validation-ui-tests' of github.com:wayneseym…

528d151

…our/kibana into ml-add-job-validation-ui-tests

wayneseymour requested a review from pheyos May 24, 2024 17:56

Merge branch 'main' into ml-add-job-validation-ui-tests

31f5136

pheyos approved these changes May 27, 2024

View reviewed changes

wayneseymour merged commit dc46dfc into elastic:main May 27, 2024
19 checks passed

kibanamachine added the v8.15.0 label May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Add AD job validation UI tests #179358

[ML] Add AD job validation UI tests #179358

wayneseymour commented Mar 25, 2024 •

edited

elasticmachine commented Mar 25, 2024

darnautov Mar 28, 2024

wayneseymour Apr 1, 2024

wayneseymour Apr 4, 2024

darnautov Apr 5, 2024 •

edited

darnautov Apr 5, 2024

wayneseymour Apr 5, 2024

wayneseymour Apr 12, 2024

wayneseymour Apr 17, 2024

darnautov Mar 28, 2024

wayneseymour Apr 17, 2024

darnautov Mar 28, 2024

wayneseymour Apr 1, 2024

wayneseymour commented May 22, 2024

wayneseymour commented May 23, 2024

wayneseymour commented May 24, 2024

pheyos left a comment

wayneseymour commented May 24, 2024

wayneseymour commented May 27, 2024

kibana-ci commented May 27, 2024

pheyos left a comment

[ML] Add AD job validation UI tests #179358

[ML] Add AD job validation UI tests #179358

Conversation

wayneseymour commented Mar 25, 2024 • edited

Summary

elasticmachine commented Mar 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darnautov Apr 5, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wayneseymour commented May 22, 2024

wayneseymour commented May 23, 2024

wayneseymour commented May 24, 2024

pheyos left a comment

Choose a reason for hiding this comment

wayneseymour commented May 24, 2024

wayneseymour commented May 27, 2024

kibana-ci commented May 27, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

History

pheyos left a comment

Choose a reason for hiding this comment

wayneseymour commented Mar 25, 2024 •

edited

darnautov Apr 5, 2024 •

edited