Table Visualization for TSVB #12813

simianhacker · 2017-07-12T21:10:20Z

This PR adds a table visualization for Time Series Visual Builder. For the most part everything works like the rest of the visualizations with a few exceptions:

The user MUST pick a group by field to aggregate the data on.
Series Aggs are not available via the normal aggregation picker. The same functionality is located in the series options.
Series can have filters that are applied only to that series (or column). This is useful for things like network traffic where you want to aggregate the series by system.network.name but you want to filter using -system.network.name:lo* to remove localhost.
Time shifting is removed (since everything is run with the same aggregation)
Sorting works only on columns where the last metric is a basic aggregation (or sortable)

Editor

On a dashboard

Series Options

Panel Options

trevan · 2017-07-13T14:28:13Z

@simianhacker, what do you mean by "id_field to pivot data on"?

I'm also curious why you are using different sort icons from the rest of the app?

simianhacker · 2017-09-28T17:14:54Z

@shaharmor The date_histogram is being used and is at the heart of TSVB, even in the TopN, Gauge, Metric and Table visualizations. This is what allows users to create metrics like "current network throughput" or any kind of rate. You need the historical data to do the derivative for those metrics. Also currently in Kibana there isn't any other way to show the value of the "last bucket" or what could be considered the "near real time" value.

mattapperson

When creating a a new vis and selecting table I am getting the error of

TypeError: Cannot read property 'order' of undefined
    at doc (/Users/mattapperson/Development/kibana/src/core_plugins/metrics/server/lib/vis_data/request_processors/table/pivot.js:47:51

Not sure if this is because I need to adjust metrics, but at the very least this should really be handled differently

mattapperson

code LGTM, just need to fix that one error

mattapperson

LGTM

shaharmor · 2017-10-23T16:16:24Z

When is this going to be merged? Are you waiting for the 6.0 GA in order to merge it to the 6.x branch?

simianhacker · 2017-10-23T16:19:56Z

@shaharmor Probably some time today :D

* Adding table vis * Making linter happy * Getting the data api inline * Fixing aggs for table vis * Fixing aggs for table vis * Adding table vis * Adding uiState and sorting * Adding sorting * Adding sorting and removing display fields * fixing color picker in timeseries and gauge; thresholds for trend arrows * Removing thresholds from trends * removing background color * remvoing obsolete tests * Fixing terminology... pivot doesn't make sense * updating error message * making the sort icons match the rest of the app * Fixing eslint bullshit * Fixing a few bugs from merges * Fixing linting issues * Adding a falsy check * Adding aria labels * Changing toggle to use a button * Adding focus-ring back in * Adding check for model and visData; they should never be null * Changing ids to use new htmlIdGenerator function * Switching to htmlIdGenerator * Fixing the way sorting works; fixing the error handling * making no data compatible with vis * Fixing defaults bug; Adding missing css rule * Fixing sorting bug

simianhacker · 2017-10-24T22:54:13Z

Back ported to 6.x with fe7e8a5

shaharmor · 2017-10-26T12:38:08Z

src/core_plugins/metrics/server/lib/vis_data/request_processors/table/date_histogram.js

+        min_doc_count: 0,
+        extended_bounds: {
+          min: from.valueOf(),
+          max: to.valueOf() - (bucketSize * 1000)


@simianhacker why do you reduce the bucketSize here?

This was removed from the rest of TSVB but because this PR languished in review for so long I forgot to remove it from here as well. I have a PR that fixes this. #14553

Thnx, should probably be removed from here as well no? https://github.com/elastic/kibana/pull/12813/files/abeeaa7224fd391aa73e3b1200888da3623e725c#diff-63d4f38a0a2ce1a25e2e18de8982c1b1R21

Oops... Added that one as well to the PR... Thanks!

shaharmor · 2017-10-26T12:38:34Z

src/core_plugins/metrics/server/lib/vis_data/request_processors/table/pivot.js

+              filter: {
+                range: {
+                  [timeField]: {
+                    gte: to.valueOf() - (bucketSize * 1500),


Also here, why change the value?

This is here for sorting, the group by terms works the same way (https://github.com/elastic/kibana/blob/master/src/core_plugins/metrics/server/lib/vis_data/request_processors/series/split_by_terms.js#L26-L44). You can't sort a terms aggregation on a metric that is a child of a date histogram so you have to create a metric outside the date histogram to sort on with a filter that approximates the last bucket. I originally took the bucket size and multiplied by 1000 milliseconds but would occasionally get strange results; using 1500 milliseconds made things more reliable. Also notice this is slightly different because it's adding the time to the gte side and not the lte side.

* Adding table vis * Making linter happy * Getting the data api inline * Fixing aggs for table vis * Fixing aggs for table vis * Adding table vis * Adding uiState and sorting * Adding sorting * Adding sorting and removing display fields * fixing color picker in timeseries and gauge; thresholds for trend arrows * Removing thresholds from trends * removing background color * remvoing obsolete tests * Fixing terminology... pivot doesn't make sense * updating error message * making the sort icons match the rest of the app * Fixing eslint bullshit * Fixing a few bugs from merges * Fixing linting issues * Adding a falsy check * Adding aria labels * Changing toggle to use a button * Adding focus-ring back in * Adding check for model and visData; they should never be null * Changing ids to use new htmlIdGenerator function * Switching to htmlIdGenerator * Fixing the way sorting works; fixing the error handling * making no data compatible with vis * Fixing defaults bug; Adding missing css rule * Fixing sorting bug

Shifter2600 · 2018-12-11T18:32:05Z

Issue when using a Date field as the Group By Field.
I have a field that is formatted to YYYY-MM and when I try to use that as my group by I get
1443657600000
1427846400000
1430438400000
....
The Columns should be taking the Field Specific Format

simianhacker added 21 commits July 6, 2017 15:49

Adding table vis

116b3ff

Merge branch 'master' of github.com:elastic/kibana into ts-table

6b71b63

Making linter happy

e7746af

Merge branch 'master' of github.com:elastic/kibana into ts-table

e8c06ae

Merge branch 'master' of github.com:elastic/kibana into ts-table

cd380ce

Getting the data api inline

d777b41

Merge branch 'master' of github.com:elastic/kibana into ts-table

1b95e29

Fixing aggs for table vis

e251756

Fixing aggs for table vis

50db961

Adding table vis

d58aae7

Merge branch 'master' of github.com:elastic/kibana into ts-table

50793f3

Merge branch 'master' of github.com:elastic/kibana into ts-table

a174651

Adding uiState and sorting

e3d3096

Adding sorting

1d9d3ef

Merge branch 'master' of github.com:elastic/kibana into ts-table

bf0d5cb

Adding sorting and removing display fields

8f8e5b0

Merge branch 'master' of github.com:elastic/kibana into ts-table

b5d4fe1

fixing color picker in timeseries and gauge; thresholds for trend arrows

a90f528

Merge branch 'master' of github.com:elastic/kibana into ts-table

87f8592

Merge branch 'master' of github.com:elastic/kibana into ts-table

88101d6

Removing thresholds from trends

7e7ea43

simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) WIP Work in progress labels Jul 12, 2017

simianhacker added 2 commits July 12, 2017 14:27

removing background color

4e9d185

remvoing obsolete tests

e46c706

simianhacker added 3 commits July 13, 2017 07:52

Fixing terminology... pivot doesn't make sense

ced0a62

updating error message

90c09f9

making the sort icons match the rest of the app

41f0a32

simianhacker requested a review from mattapperson October 3, 2017 15:49

Merge branch 'master' into ts-table

69aa002

mattapperson reviewed Oct 18, 2017

View reviewed changes

mattapperson suggested changes Oct 18, 2017

View reviewed changes

simianhacker added 3 commits October 18, 2017 13:46

Merge branch 'master' of github.com:elastic/kibana into ts-table

48adff8

Merge branch 'ts-table' of github.com:simianhacker/kibana into ts-table

beecab1

making no data compatible with vis

ed1ec19

mattapperson approved these changes Oct 18, 2017

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into ts-table

3593913

simianhacker added 4 commits October 23, 2017 09:59

Fixing defaults bug; Adding missing css rule

43832eb

Fixing sorting bug

b9232d3

Merge branch 'master' of github.com:elastic/kibana into ts-table

bcde9e6

Merge branch 'master' of github.com:elastic/kibana into ts-table

abeeaa7

simianhacker merged commit d891623 into elastic:master Oct 24, 2017

shaharmor reviewed Oct 26, 2017

View reviewed changes

stacey-gammon mentioned this pull request Nov 3, 2017

Can't add multiple vis to a dashboard in one go #14661

Closed

simianhacker mentioned this pull request Nov 4, 2017

[TSVB] Fix weird merge problem with Table PR #14774

Merged

alexfrancoeur mentioned this pull request Dec 1, 2017

Support filter (not filter_s_) aggregation in datatable visualization #15300

Closed

alexfrancoeur mentioned this pull request Dec 15, 2017

Option to show percentage #2284

Closed

simianhacker mentioned this pull request Feb 19, 2021

[TSVB] Remove the broken "aggregate function" in TSVB table #91149

Closed

simianhacker deleted the ts-table branch April 17, 2024 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Table Visualization for TSVB #12813

Table Visualization for TSVB #12813

simianhacker commented Jul 12, 2017 •

edited

trevan commented Jul 13, 2017

simianhacker commented Sep 28, 2017

mattapperson left a comment

mattapperson left a comment

mattapperson left a comment

shaharmor commented Oct 23, 2017

simianhacker commented Oct 23, 2017

simianhacker commented Oct 24, 2017

shaharmor Oct 26, 2017

simianhacker Oct 26, 2017

shaharmor Oct 26, 2017

simianhacker Oct 26, 2017

shaharmor Oct 26, 2017

simianhacker Oct 26, 2017

Shifter2600 commented Dec 11, 2018

Table Visualization for TSVB #12813

Table Visualization for TSVB #12813

Conversation

simianhacker commented Jul 12, 2017 • edited

trevan commented Jul 13, 2017

simianhacker commented Sep 28, 2017

mattapperson left a comment

Choose a reason for hiding this comment

mattapperson left a comment

Choose a reason for hiding this comment

mattapperson left a comment

Choose a reason for hiding this comment

shaharmor commented Oct 23, 2017

simianhacker commented Oct 23, 2017

simianhacker commented Oct 24, 2017

shaharmor Oct 26, 2017

Choose a reason for hiding this comment

simianhacker Oct 26, 2017

Choose a reason for hiding this comment

shaharmor Oct 26, 2017

Choose a reason for hiding this comment

simianhacker Oct 26, 2017

Choose a reason for hiding this comment

shaharmor Oct 26, 2017

Choose a reason for hiding this comment

simianhacker Oct 26, 2017

Choose a reason for hiding this comment

Shifter2600 commented Dec 11, 2018

simianhacker commented Jul 12, 2017 •

edited