[Canvas] By-Value Embeddables #113827

cqliu1 · 2021-10-04T18:25:01Z

Summary

Related to #108439.
Closes #101633.
Closes #81812.
Closes #101628.

This introduces support for by-value embeddables in Canvas and adds the same workflow as Dashboard for creating new visualizations/embeddables from external editors.

This merges the by-value embeddables feature branch into master. All commits in this PR have been reviewed individually, and this PR doesn't contain any additional changes beyond those.

This branch contains the following reviewed PRs:

4b794de: Generic embeddable function [Canvas] Generic embeddable function #104499
b041d8b: Save and Return flow [Canvas] Adds Save and Return Workflow #111411
150dcaf: Editor Menu [Canvas] Adds editor menu to Canvas #113194
c6cc47a: Preserve original input [Canvas] Use original input when updating existing embeddable #116026
46edbbe: extract/inject saved object references [Canvas] Extract and inject references for by-value embeddables #115124

For reviewers:

@elastic/kibana-telemetry @elastic/kibana-core The only telemetry and core changes were made in #104499.

Future enhancements that will not be addressed in the initial phase of this feature

Enable ML Embeddables in Canvas [Canvas] Enable ML Embeddables in Canvas #113309
- ML embeddables are throwing an error after enabling them in Canvas. Needs more research
Removing the by-value lab flag [Canvas] Removes by-value embeddable lab flag #115277
Add to/remove from library actions available in Canvas
Support color palette in embeddables function [Canvas] Adds support for palette in embeddable function #115278

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2021-10-19T22:36:37Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 34831c5
Storybooks not built
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures
Documentation Changes

Failed CI Steps

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [94e1144]

History

💔 Build #162990 failed 34831c5
💔 Build #162802 failed f8dbcaf
💚 Build #162216 succeeded 196b94d
💚 Build #161635 succeeded 6b2bc48

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2021-10-26T15:43:14Z

Pinging @elastic/kibana-presentation (Team:Presentation)

cqliu1 · 2021-10-26T19:51:43Z

@elasticmachine merge upstream

crob611

Everything looks good to me 👍

kibanamachine · 2021-10-26T22:42:35Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`canvas`	1070	1082	+12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`presentationUtil`	151	160	+9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.0MB	1.0MB	+33.0KB
`dashboard`	143.3KB	143.3KB	+2.0B
total			+33.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`canvas`	17.3KB	17.6KB	+275.0B
`presentationUtil`	43.4KB	44.8KB	+1.4KB
total			+1.6KB

Unknown metric groups

API count

id	before	after	diff
`presentationUtil`	178	187	+9

References to deprecated APIs

id	before	after	diff
`canvas`	67	70	+3

History

💔 Build #1845 failed dc6a861
💚 Build #1659 succeeded d3e9f7d
💚 Build #1584 succeeded 151ceac
💚 Build #1278 succeeded 780f71c
💚 Build #762 succeeded c637735

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…-migrate-away-from-injected-css-js * 'master' of github.com:elastic/kibana: (61 commits) [ML] Nodes overview for the Model Management page (elastic#116361) [Uptime] Uptime index config using kibana.yml (elastic#115775) [Controls] Dashboard Integration (elastic#115991) skip flaky suite (elastic#104260) Include Files in GitHub UI (elastic#115956) skip flaky suite (elastic#116060) [Canvas] By-Value Embeddables (elastic#113827) Skip failing test (elastic#115366) [Osquery] Fix live query search doesn't return relevant results for agents (elastic#116332) [Integrations] Added link in old Add Data description and fixed alignment in cards (elastic#116213) [Actions] Extended ActionTypeRegistry with connector validation to validate config with secrets (elastic#116079) skip flaky suite (elastic#109329) Grant access to machine learning features when base privileges are used (elastic#115444) Skipping failing test (elastic#84957) [RAC][Security Solution] Adds migration to new SecuritySolution rule types (elastic#112113) skip flaky suite (elastic#115366) [Fleet] Marking API spec as experimental (elastic#116331) [Docs] Cleaning up the versions in the upgrade paths. Closes elastic#116223 (elastic#116228) [Reporting] Suppress debug logs in the mock logger (elastic#116012) [Metrics UI] Clear threshold alert groups state when filterQuery changes (elastic#116205) ... # Conflicts: # src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx # src/plugins/dashboard/public/types.ts

This reverts commit bacd7f9.

This reverts commit bacd7f9. Co-authored-by: spalger <spalger@users.noreply.github.com>

spalger · 2021-10-28T01:39:16Z

Please see #116527 about revert

This reverts commit bacd7f9. Co-authored-by: spalger <spalger@users.noreply.github.com>

…6539) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com>

…tic#116527)" This reverts commit 9e6e845.

…117613) * Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)" This reverts commit 9e6e845. * Fix ts error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…tic#116527)" (elastic#117613) * Revert "Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)" This reverts commit 9e6e845. * Fix ts error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…117613) (#117751) * Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)" This reverts commit 9e6e845. * Fix ts error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

cqliu1 force-pushed the canvas/by-value-embeddables branch 2 times, most recently from ddb8632 to b706dfd Compare October 5, 2021 20:57

cqliu1 force-pushed the canvas/by-value-embeddables branch 3 times, most recently from afea023 to 6b2bc48 Compare October 15, 2021 19:47

cqliu1 mentioned this pull request Oct 15, 2021

[Canvas] Removes by-value embeddable lab flag #115277

Closed

9 tasks

cqliu1 force-pushed the canvas/by-value-embeddables branch 2 times, most recently from 7557017 to f8dbcaf Compare October 19, 2021 16:00

cqliu1 mentioned this pull request Oct 19, 2021

[Canvas] Enable ML Embeddables in Canvas #113309

Closed

9 tasks

cqliu1 force-pushed the canvas/by-value-embeddables branch from f8dbcaf to 34831c5 Compare October 19, 2021 22:18

cqliu1 force-pushed the canvas/by-value-embeddables branch 4 times, most recently from 1834014 to 151ceac Compare October 25, 2021 20:02

cqliu1 marked this pull request as ready for review October 26, 2021 15:43

cqliu1 requested review from a team as code owners October 26, 2021 15:43

cqliu1 force-pushed the canvas/by-value-embeddables branch from e5e3dad to 46edbbe Compare October 26, 2021 15:46

Merge branch 'master' into canvas/by-value-embeddables

542951d

crob611 approved these changes Oct 26, 2021

View reviewed changes

cqliu1 merged commit bacd7f9 into master Oct 27, 2021

dmlemeshko mentioned this pull request Oct 27, 2021

[Canvas] duplicated API call on loading workpad #114340

Closed

cqliu1 deleted the canvas/by-value-embeddables branch October 27, 2021 18:58

brianseeders added a commit to brianseeders/kibana that referenced this pull request Oct 27, 2021

Revert "[Canvas] By-Value Embeddables (elastic#113827)"

ccc41c2

This reverts commit bacd7f9.

brianseeders added a commit to brianseeders/kibana that referenced this pull request Oct 27, 2021

Revert "[Canvas] By-Value Embeddables (elastic#113827)"

ad6b4a4

This reverts commit bacd7f9.

spalger added a commit to spalger/kibana that referenced this pull request Oct 27, 2021

Revert "[Canvas] By-Value Embeddables (elastic#113827)"

d29490c

This reverts commit bacd7f9.

spalger added a commit that referenced this pull request Oct 28, 2021

Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)

9e6e845

This reverts commit bacd7f9. Co-authored-by: spalger <spalger@users.noreply.github.com>

spalger added the reverted label Oct 28, 2021

kibanamachine mentioned this pull request Oct 28, 2021

[8.0] Revert "[Canvas] By-Value Embeddables (#113827)" (#116527) #116539

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2021

Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)

9260184

This reverts commit bacd7f9. Co-authored-by: spalger <spalger@users.noreply.github.com>

academo pushed a commit to academo/kibana that referenced this pull request Oct 28, 2021

Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)

677f8db

This reverts commit bacd7f9. Co-authored-by: spalger <spalger@users.noreply.github.com>

nkhristinin pushed a commit to nkhristinin/kibana that referenced this pull request Oct 28, 2021

Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elastic#116527)

e1ef43f

This reverts commit bacd7f9. Co-authored-by: spalger <spalger@users.noreply.github.com>

cqliu1 mentioned this pull request Oct 28, 2021

[Canvas] By Value Embeddables #116540

Closed

9 tasks

spalger added a commit that referenced this pull request Nov 1, 2021

[8.0] Revert "[Canvas] By-Value Embeddables (#113827)" (#116527) (#11…

4359e70

…6539) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com>

cqliu1 mentioned this pull request Nov 2, 2021

Canvas/by value embeddables test #116731

Closed

9 tasks

cqliu1 added a commit to cqliu1/kibana that referenced this pull request Nov 5, 2021

Revert "Revert "[Canvas] By-Value Embeddables (elastic#113827)" (elas…

8ecc714

…tic#116527)" This reverts commit 9e6e845.

cqliu1 mentioned this pull request Nov 5, 2021

[Canvas] By-Value Embeddables #117613

Merged

9 tasks

cqliu1 mentioned this pull request Nov 5, 2021

[8.0] Revert "Revert "[Canvas] By-Value Embeddables (#113827)" (#116527)" (#117613) #117751

Merged

cqliu1 removed the WIP Work in progress label Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canvas] By-Value Embeddables #113827

[Canvas] By-Value Embeddables #113827

cqliu1 commented Oct 4, 2021 •

edited

kibanamachine commented Oct 19, 2021 •

edited

elasticmachine commented Oct 26, 2021

cqliu1 commented Oct 26, 2021

crob611 left a comment

kibanamachine commented Oct 26, 2021

API count

References to deprecated APIs

spalger commented Oct 28, 2021

[Canvas] By-Value Embeddables #113827

[Canvas] By-Value Embeddables #113827

Conversation

cqliu1 commented Oct 4, 2021 • edited

Summary

For reviewers:

Future enhancements that will not be addressed in the initial phase of this feature

Checklist

For maintainers

kibanamachine commented Oct 19, 2021 • edited

💔 Build Failed

Failed CI Steps

Metrics [docs]

History

elasticmachine commented Oct 26, 2021

cqliu1 commented Oct 26, 2021

crob611 left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 26, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

References to deprecated APIs

History

spalger commented Oct 28, 2021

cqliu1 commented Oct 4, 2021 •

edited

kibanamachine commented Oct 19, 2021 •

edited