Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_delete_by_query syntax doesn't autocomplete in dev tools #181618

Closed
seanstory opened this issue Apr 24, 2024 · 2 comments · Fixed by #182002
Closed

_delete_by_query syntax doesn't autocomplete in dev tools #181618

seanstory opened this issue Apr 24, 2024 · 2 comments · Fixed by #182002
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@seanstory
Copy link
Member

Kibana version:
8.14.0-SNAPSHOT

Elasticsearch version:
8.14.0-SNAPSHOT

Server OS version:
Cloud

Browser version:
Chrome 123.0.6312.105 (Official Build) (arm64)

Browser OS version:
OSX 14.4.1

Original install method (e.g. download page, yum, from source, etc.):
Cloud

Describe the bug:
In dev tools, I can type POST <index>/_del and it will autocomplete to POST <index>/_delete_by_query

However, the JSON body query syntax does not autocomplete. So if I want to run:

POST <index>/_delete_by_query
{
  "query": {
    "match_all": {}
  }
}

I have to type it all out by hand. However, the same query will autocomplete in the body just fine for _search

Steps to reproduce:

  1. Go to dev tools
  2. Form a query to delete all docs in an index
  3. notice lack of autocomplete

Expected behavior:
Delete-by-query should autocomplete just like _search
@seanstory seanstory added the bug Fixes for quality problems that affect the customer experience label Apr 24, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 24, 2024
@seanstory
Copy link
Member Author

@alisonelizabeth , I was told that you're the right person to tag?

@jsanz jsanz added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 29, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@kderusso kderusso mentioned this issue Apr 29, 2024
Merged
kderusso added a commit that referenced this issue Apr 30, 2024
@kderusso @kibanamachine
[Dev console] Fix some issues with AutoComplete (#182002)
5814f2e 
Resolves #181618 by adding
delete by query AutoComplete for the query.

Here's what it looks like now: 


https://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1

Also fixes a syntax issue with rule query AutoComplete where we added an
extra `query` that would result in a syntax error.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Apr 30, 2024
@kderusso
[Dev console] Fix some issues with AutoComplete (elastic#182002)
138adbb 
Resolves elastic#181618 by adding
delete by query AutoComplete for the query.

Here's what it looks like now:

https://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1

Also fixes a syntax issue with rule query AutoComplete where we added an
extra `query` that would result in a syntax error.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 5814f2e)
kibanamachine added a commit that referenced this issue Apr 30, 2024
@kibanamachine @kderusso
[8.14] [Dev console] Fix some issues with AutoComplete (#182002) (#18…
d2f93a6 
…2123)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Dev console] Fix some issues with AutoComplete
(#182002)](#182002)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kathleen
DeRusso","email":"kathleen.derusso@elastic.co"},"sourceCommit":{"committedDate":"2024-04-30T13:17:01Z","message":"[Dev
console] Fix some issues with AutoComplete (#182002)\n\nResolves
#181618 by adding\r\ndelete by
query AutoComplete for the query.\r\n\r\nHere's what it looks like now:
\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1\r\n\r\nAlso
fixes a syntax issue with rule query AutoComplete where we added
an\r\nextra `query` that would result in a syntax
error.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5814f2e0cea6a2ad797c10105badbbc313635bdd","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.14.0","v8.15.0"],"title":"[Dev
console] Fix some issues with
AutoComplete","number":182002,"url":"#182002
console] Fix some issues with AutoComplete (#182002)\n\nResolves
#181618 by adding\r\ndelete by
query AutoComplete for the query.\r\n\r\nHere's what it looks like now:
\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1\r\n\r\nAlso
fixes a syntax issue with rule query AutoComplete where we added
an\r\nextra `query` that would result in a syntax
error.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5814f2e0cea6a2ad797c10105badbbc313635bdd"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182002
console] Fix some issues with AutoComplete (#182002)\n\nResolves
#181618 by adding\r\ndelete by
query AutoComplete for the query.\r\n\r\nHere's what it looks like now:
\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1\r\n\r\nAlso
fixes a syntax issue with rule query AutoComplete where we added
an\r\nextra `query` that would result in a syntax
error.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"5814f2e0cea6a2ad797c10105badbbc313635bdd"}}]}]
BACKPORT-->

Co-authored-by: Kathleen DeRusso <kathleen.derusso@elastic.co>
yuliacech pushed a commit to yuliacech/kibana that referenced this issue May 3, 2024
@kderusso @kibanamachine @yuliacech
[Dev console] Fix some issues with AutoComplete (elastic#182002)
9a8097f 
Resolves elastic#181618 by adding
delete by query AutoComplete for the query.

Here's what it looks like now: 


https://github.com/elastic/kibana/assets/63422879/ff2c0c18-4f1e-41f3-b18d-b9a4a5377dd1

Also fixes a syntax issue with rule query AutoComplete where we added an
extra `query` that would result in a syntax error.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dev console] Fix some issues with AutoComplete kderusso/kibana
3 participants
@jsanz @seanstory @elasticmachine