-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP - do not merge] Content section for writing guidelines in EUI #7710
Draft
florent-leborgne
wants to merge
12
commits into
elastic:feat/new-docs
Choose a base branch
from
florent-leborgne:feat/writing-section
base: feat/new-docs
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP - do not merge] Content section for writing guidelines in EUI #7710
florent-leborgne
wants to merge
12
commits into
elastic:feat/new-docs
from
florent-leborgne:feat/writing-section
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've pushed additional changes on punctuation and case, as well as minor changes to general style recommendations. Please have a look. |
florent-leborgne
requested review from
szabosteve,
nastasha-solomon and
mdbirnstiehl
May 17, 2024 15:55
I ported some of the relevant content currently under EUI > Writing to our new file structure, adding content about being conversational, minimalism, use of adverbs, and a few more things. Please have a look. |
This reverts commit 86aee70.
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Update spelling section
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Content section on the new EUI site.
It also reworks entirely the content that was previously found under eui.elastic.co/writing.
This is a WIP and we'll be working more on it in the coming days.
Content is not ready.