Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile - Rename access to labels for request, response and mappings #85797

Merged
merged 8 commits into from Apr 13, 2022

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Apr 12, 2022

It is agreed that the "access" field should be renamed to the more
generic "labels". Data stored in this field are meant to be application
specific (similar to "data" but searchable) and ES does not attempt to
understand its content or purpose. Hence the more generic name is a
better fit.

It is agreed that the "access" field should be renamed to the more
generic "labels". Data stored in this field are meant to be application
specific (similar to "data" but searchable) and ES does not attempt to
understand its content or purpose. Hence the more generic name is a
better fit.
@ywangd ywangd added >enhancement :Security/Security Security issues without another label Team:Clients Meta label for clients team v8.3.0 labels Apr 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticmachine elasticmachine added the Team:Security Meta label for security team label Apr 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Hi @ywangd, I've created a changelog YAML for you.

Copy link
Contributor

@n1v0lg n1v0lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two possible typos. Build failure looks unrelated.

@ywangd ywangd added v8.2.0 auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Apr 12, 2022
@ywangd
Copy link
Member Author

ywangd commented Apr 12, 2022

@elasticmachine run elasticsearch-ci/part-1-fips

@ywangd
Copy link
Member Author

ywangd commented Apr 12, 2022

@elasticmachine update branch

@ywangd
Copy link
Member Author

ywangd commented Apr 13, 2022

FIPS failure is this issue #85803

@ywangd
Copy link
Member Author

ywangd commented Apr 13, 2022

@elasticmachine run elasticsearch-ci/part-1

@ywangd
Copy link
Member Author

ywangd commented Apr 13, 2022

@elasticmachine update branch

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd merged commit 1269378 into elastic:master Apr 13, 2022
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Apr 13, 2022
…ings (elastic#85797)

It is agreed that the "access" field should be renamed to the more
generic "labels". Data stored in this field are meant to be application
specific (similar to "data" but searchable) and ES does not attempt to
understand its content or purpose. Hence the more generic name is a
better fit.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.2

elasticsearchmachine pushed a commit that referenced this pull request Apr 14, 2022
…ings (#85797) (#85883)

It is agreed that the "access" field should be renamed to the more
generic "labels". Data stored in this field are meant to be application
specific (similar to "data" but searchable) and ES does not attempt to
understand its content or purpose. Hence the more generic name is a
better fit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >non-issue :Security/Security Security issues without another label Team:Clients Meta label for clients team Team:Security Meta label for security team v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants