[Tests] Add unit tests for InternalFilters #24624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
:Analytics/Aggregations
javanna
approved these changes
May 12, 2017
| } | ||
|
|
||
| private final List<InternalBucket> buckets; | ||
| private final boolean keyed; | ||
| private Map<String, InternalBucket> bucketMap; | ||
| transient private Map<String, InternalBucket> bucketMap; |
There was a problem hiding this comment.
I think that the build may complain about order of modifiers. Maybe add a comment on why this field is transient?
cbuescher
force-pushed
the
add-InternalFiltersTests
branch
from
652a67b
to
d835246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #22278