Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add unit tests for Range aggregations #24569

Merged
merged 2 commits into from
May 10, 2017

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented May 9, 2017

Related to #22278

@tlrx tlrx added :Analytics/Aggregations Aggregations review >test Issues or PRs that are addressing/adding tests v5.5.0 v6.0.0 labels May 9, 2017
@tlrx tlrx requested a review from jpountz May 10, 2017 07:25
double from = i * interval;
double to = from + interval;
listOfRanges.add(Tuple.tuple(from, to));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should also generate overlapping ranges?

@tlrx tlrx removed the v5.5.0 label May 10, 2017
@tlrx tlrx merged commit 2fe53be into elastic:master May 10, 2017
@tlrx
Copy link
Member Author

tlrx commented May 10, 2017

Thanks @jpountz ! I added some overlapping ranges as you suggested.

@tlrx tlrx deleted the add-unit-tests-range-aggs branch May 10, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v6.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants