Add base class for writing unit test for aggregations #22279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
>test
63 tasks
javanna
reviewed
Dec 20, 2016
| * Base class for testing {@link Aggregator} implementations. | ||
| * Provides a helper constructing the {@link Aggregator} implementation based on a provided {@link AggregationBuilder} instance. | ||
| */ | ||
| public abstract class AggregratorTestCase extends ESTestCase { |
jpountz
changed the title
jpountz
approved these changes
Dec 20, 2016
| when(searchContext.getQueryShardContext()).thenReturn(queryShardContext); | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| A aggregator = (A) aggregatorBuilder.build(searchContext, null).create(null, true); |
There was a problem hiding this comment.
I don't think the generics on this method are buying anything since we do a blind cast here?
There was a problem hiding this comment.
The reason I did the cast here is that we don't have to do the cast in all tests that need an aggregator.
| aggregator.postCollection(); | ||
| InternalMin result = (InternalMin) aggregator.buildAggregation(0L); | ||
| assertEquals(-1.0, result.getValue(), 0); | ||
| } |
There was a problem hiding this comment.
can you also test what happens when no docs match the query?
There was a problem hiding this comment.
or when some docs match the query but do not have a value
| */ | ||
| public abstract class AggregatorTestCase extends ESTestCase { | ||
|
|
||
| protected <A extends Aggregator, B extends AggregationBuilder> A createAggregator(B aggregatorBuilder, |
There was a problem hiding this comment.
can you call it aggregationBuilder rather than aggregatorBuilder to be more consistent with the class name?
jpountz
approved these changes
Dec 20, 2016
martijnvg
force-pushed
the
aggregator_unit_tests
branch
from
7b847a0
to
0346583
Compare
…terms`, `top_hits` and `min` aggregations.
martijnvg
force-pushed
the
aggregator_unit_tests
branch
from
0346583
to
417746c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some initial tests for some aggregations.
First PR for #22278.