Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): add table view for legend stats #2426

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented May 8, 2024

Summary

Implements table view for legend statistics. The table shows up automatically when user chooses any statistic other than CurrentAndLastValue for xy charts only.

Screenshot 2024-05-16 at 15 40 04

Details

For the charts that don't have the new legend values added, the legacy view is displayed.

Issues

part of #2096

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with light and dark themes

@nickofthyme nickofthyme changed the title Feat legends stats feat(legend): stats May 8, 2024
@mbondyra mbondyra force-pushed the feat_legends_stats branch 8 times, most recently from 7c7aa4d to 61da4e8 Compare May 15, 2024 10:34
@mbondyra mbondyra added :legend Legend related issue :xy Bar/Line/Area chart related labels May 15, 2024
@mbondyra mbondyra changed the title feat(legend): stats feat(legend): add table view for legend stats May 16, 2024
@mbondyra mbondyra force-pushed the feat_legends_stats branch 11 times, most recently from f7ced69 to d19292b Compare May 20, 2024 13:30
@mbondyra mbondyra force-pushed the feat_legends_stats branch 6 times, most recently from a29e5cb to 693a688 Compare May 26, 2024 14:14
@elastic-datavis
Copy link
Contributor

✅ Successful Deployment (build#3740) - cd7eda5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:legend Legend related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant