New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legend): Improve interactions legend labels #2418
Conversation
buildkite update screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this for now, we have multiple other strings that need to be i18nzed so I believe we should consider a more general approach than a scoped i18n set of labels just for the legend here.
For now is also fine having hardcoded english strings. We should then provide a way to internationalize tokens like EUI is doing
buildkite update screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me, works as expected!
# [65.0.0](v64.1.0...v65.0.0) (2024-05-20) ### Bug Fixes * **barSeries:** error rendering bars with negative log scale ([#2407](#2407)) ([4ab6d8f](4ab6d8f)) * **deps:** update dependency @elastic/eui to ^93.5.1 ([#2375](#2375)) ([35ed956](35ed956)) * **deps:** update dependency @elastic/eui to ^93.5.2 ([#2386](#2386)) ([e26c6dd](e26c6dd)) * **deps:** update dependency @elastic/eui to ^93.6.0 ([#2393](#2393)) ([40f2b7b](40f2b7b)) * **deps:** update dependency @elastic/eui to ^94.3.0 ([#2424](#2424)) ([cff5181](cff5181)) * **deps:** update dependency @elastic/eui to v94 ([#2409](#2409)) ([67c814f](67c814f)) * **deps:** update dependency @playwright/test to ^1.43.0 ([#2388](#2388)) ([42f86d7](42f86d7)) * **deps:** update dependency @playwright/test to ^1.43.1 ([#2413](#2413)) ([79b1c7f](79b1c7f)) * **deps:** update dependency json-schema-to-typescript to v14 ([#2414](#2414)) ([785f635](785f635)) * **deps:** update dependency json-schema-to-typescript to v14.0.4 ([#2421](#2421)) ([790170a](790170a)) * **legend:** custom legend covered by background ([#2366](#2366)) ([5b9ffac](5b9ffac)) ### Features * add support for start day of week on MLT axis ([#2362](#2362)) ([3aac1f0](3aac1f0)) * **Legend:** change click on item behaviour ([#2427](#2427)) ([b1c72df](b1c72df)) * **legend:** change click on item behaviour ([#2431](#2431)) ([b03bdd0](b03bdd0)) * **legend:** Improve interactions legend labels ([#2418](#2418)) ([384baac](384baac)) * **legend:** select legend statistic value ([#2355](#2355)) ([a602838](a602838)) * **metric:** support array of values ([#2428](#2428)) ([e448bd7](e448bd7)) ### Reverts * **legend:** change click on item behaviour ([#2429](#2429)) ([cc438a1](cc438a1)), closes [#2427](#2427) ### BREAKING CHANGES * **legend:** The legend modifier key has been changed to CTRL (or CMD on Mac) from SHIFT. The SHIFT key will no longer have any effect on click.
Summary
Provide a new messaging about interactivity options:
Details
This PR improves the accessibility about legend item interactivity via new messaging through the
title
attribute of each legend item.Issues
This is a complementary feature of #2427
Fix #1339
Checklist
:interactions
,:axis
)closes #123
,fixes #123
)