Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: direct manipulation #1660

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from
Draft

feat: direct manipulation #1660

wants to merge 56 commits into from

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Apr 28, 2022 •
edited

Summary

Quick prototype to check the utility of direct manipulation in elastic-charts

image

Details

Issues

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The :theme label has been added and the @elastic/eui-design team has been pinged when there are Theme API changes
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@monfera monfera added the :interactions Interactions related issue label Apr 28, 2022
@monfera monfera marked this pull request as draft April 28, 2022 09:34
monfera and others added 18 commits April 30, 2022 15:06
@monfera
temporarily disabled the top x axis label
15aa90a
@monfera
projection example improvement
bcabe59
@monfera
projection example improvement 2 - handles
61ace7a
@monfera
still slow as it still computes the delaunay
a1c09dc
@monfera
reimagining the dimensions
4f1cc07
@monfera
adding timeslip onto the projection
75d423f
@monfera
temporarily disable delaunay in one of the stories
662ca17
@monfera
minor tweaks
ce505cb
@markov00
update marginal scatterplot lnf
f4f3505
@monfera
minor ts fixes
cb9820f
@monfera
put heatmap in the group
e39ae75
@monfera
explicit background coloring 1
6132026
@monfera
aeroelastic: ts fixes
fc0ff2f 
(cherry picked from commit 50716d6163738aa064c851420a95a844e3e0636f)
@monfera
aeroelastic: must work with a single element too
e0ed486
@monfera
aeroelastic: key fix ht Marco
ef3f8a9
@monfera
no export necessary
f3e7c1d
@monfera
aeroelastic: better ungrouped example
0cb3b53
@nickofthyme
Merge branch 'master' into aeroelastic
bee8a53
@nickofthyme nickofthyme added the ci:skip Skip all build checks label Jun 29, 2022
@nickofthyme nickofthyme changed the base branch from master to main December 14, 2022 01:06
@markov00
Copy link
Member

buildkite test this

@elastic-datavis elastic-datavis bot removed the ci:skip Skip all build checks label Dec 14, 2022
@elastic-datavis
Copy link
Contributor

Community pull request, @elastic/datavis please add the ci:approved ✅ label to allow this and future builds.

@nickofthyme nickofthyme added the ci:approved ✅ Approves PR builds label Dec 14, 2022
@elastic-datavis
Copy link
Contributor

Deployments - bee8a53

  • Storybook (link)
  • e2e server (link)
  • Playwright report (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:approved ✅ Approves PR builds :interactions Interactions related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@monfera @markov00 @nickofthyme