Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTest] Remove retry library and use utils.py retryable decorator #1578

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

timgrein
Copy link
Contributor

@timgrein timgrein commented Sep 5, 2023

Related to #1566

This PR removes the retry library (only used once) as we're having exactly that functionality already implemented with our retryable decorator.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

jedrazb
jedrazb previously approved these changes Sep 6, 2023
@timgrein
Copy link
Contributor Author

timgrein commented Sep 6, 2023

@retryable doesn't work for non-async functions. Will provide a PR for that functionality first.

Addressed in/depends on #1587.

@timgrein timgrein enabled auto-merge (squash) September 7, 2023 09:42
@timgrein timgrein merged commit c9e1ae2 into main Sep 7, 2023
2 checks passed
@timgrein timgrein deleted the tim/remove-retry-library branch September 7, 2023 09:46
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 1578 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants