Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset inventory AWS RDS fetcher #2194

Merged
merged 8 commits into from May 16, 2024

Conversation

kubasobon
Copy link
Member

@kubasobon kubasobon commented May 9, 2024

Summary of your changes

Adds an AWS RDS instance fetcher.

Screenshot/Data

Screenshot 2024-05-13 at 12 18 39

image

Related Issues

Closes https://github.com/elastic/security-team/issues/9083

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

no

Copy link

mergify bot commented May 9, 2024

This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label May 9, 2024
Copy link

github-actions bot commented May 9, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@kubasobon kubasobon marked this pull request as ready for review May 14, 2024 10:16
@kubasobon kubasobon requested a review from a team as a code owner May 14, 2024 10:16
@kubasobon kubasobon changed the title WIP: Add asset inventory AWS RDS fetcher Add asset inventory AWS RDS fetcher May 14, 2024
@kubasobon kubasobon requested a review from romulets May 14, 2024 11:24
@oren-zohar
Copy link
Collaborator

oren-zohar commented May 15, 2024

Why is there database twice in the index name?
image
Actually the same question sands for the s3 as well @romulets

@oren-zohar
Copy link
Collaborator

It's also unclear to me what the convention is for the index name when using - and _, I thought - is saved for the namespace. @romulets

@kubasobon
Copy link
Member Author

@oren-zohar The index name is constructed here

func generateIndex(a Asset) string {
	return fmt.Sprintf("asset_inventory_%s_%s_%s_%s", a.Category, a.SubCategory, a.Type, a.SubType)
}

Type changed to relational-database, so it will be a bit different now. Subdivision is based on this chart.

@kubasobon kubasobon merged commit 4505eaa into elastic:main May 16, 2024
24 checks passed
@kubasobon kubasobon deleted the inventory-aws-rds branch May 16, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants